keyring: add key for Stewart X Addison#52
Conversation
|
You need to run |
|
Linters look happy now |
aduh95
left a comment
There was a problem hiding this comment.
And no more trustdb issues :)
|
The GOVERNANCE.md only mentions I guess the other option would be a |
|
Force push to add signing to the last commit. |
|
Force push to squash additional commit before merging. No additional changes. |
|
nit: the commit message should contain the PR number (i.e. |
Signed-off-by: Stewart X Addison <sxa@ibm.com>
Fixed - I'll assume you're approval still stands :-) |
Part of nodejs/Release#733
Note to reviewers particularly @aduh95 since I believe he did the keyring split: I added my key and then used
cli.sh addwhich added it to the twopubring.kbxfiles but did not make changes totrustdb.gpg. Is that ok? Most other PRs to change keys seem to edit both (although maybe that's a revocation specific thing as Ulises initial addition in nodejs/node#49196 didn't update that either)