Skip to content

keyring: add key for Stewart X Addison#52

Merged
aduh95 merged 1 commit into
nodejs:mainfrom
sxa:add_sxa_ed25519
Jul 1, 2026
Merged

keyring: add key for Stewart X Addison#52
aduh95 merged 1 commit into
nodejs:mainfrom
sxa:add_sxa_ed25519

Conversation

@sxa

@sxa sxa commented Jul 1, 2026

Copy link
Copy Markdown
Member

Part of nodejs/Release#733

Note to reviewers particularly @aduh95 since I believe he did the keyring split: I added my key and then used cli.sh add which added it to the two pubring.kbx files but did not make changes to trustdb.gpg. Is that ok? Most other PRs to change keys seem to edit both (although maybe that's a revocation specific thing as Ulises initial addition in nodejs/node#49196 didn't update that either)

@sxa sxa requested a review from aduh95 July 1, 2026 12:15
@aduh95

aduh95 commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

You need to run ./generate-gpg-dir.sh and yourself to the README to make the linter happy

Comment thread README.md Outdated
@sxa

sxa commented Jul 1, 2026

Copy link
Copy Markdown
Member Author

Linters look happy now

@aduh95 aduh95 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And no more trustdb issues :)

@sxa

sxa commented Jul 1, 2026

Copy link
Copy Markdown
Member Author

The GOVERNANCE.md only mentions cli.sh so (while I'm on a documentation roll) I'll look at another PR to that to mention that the README.md and ./generate-gpg-dir.sh stuff too.

I guess the other option would be a CONTRIBUTING.md either to hold that information or just point at the Release repo's GOVERNANACE.md

@sxa sxa force-pushed the add_sxa_ed25519 branch from 07cab96 to 2c045fa Compare July 1, 2026 13:05
@sxa

sxa commented Jul 1, 2026

Copy link
Copy Markdown
Member Author

Force push to add signing to the last commit.

@sxa sxa force-pushed the add_sxa_ed25519 branch from 2c045fa to cad9561 Compare July 1, 2026 13:31
@sxa

sxa commented Jul 1, 2026

Copy link
Copy Markdown
Member Author

Force push to squash additional commit before merging. No additional changes.

@aduh95

aduh95 commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

nit: the commit message should contain the PR number (i.e. keyring: add key for Stewart X Addison (#52))

Signed-off-by: Stewart X Addison <sxa@ibm.com>
@sxa sxa force-pushed the add_sxa_ed25519 branch from cad9561 to 890d535 Compare July 1, 2026 13:39
@sxa

sxa commented Jul 1, 2026

Copy link
Copy Markdown
Member Author

nit: the commit message should contain the PR number (i.e. keyring: add key for Stewart X Addison (#52))

Fixed - I'll assume you're approval still stands :-)

@aduh95 aduh95 merged commit 890d535 into nodejs:main Jul 1, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants