Skip to content

Fix swapped definitions of basal/functional layers of endometrium (#3803) - #3807

Merged
dosumis merged 5 commits into
masterfrom
ai4c-agent-issue-3803-run2160
Oct 29, 2026
Merged

dosumis merged 5 commits into
masterfrom
ai4c-agent-issue-3803-run2160

Conversation

@ai4c-agent

@ai4c-agent ai4c-agent Bot commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

Fixes #3803

Changes

UBERON:0022355 basal layer of endometrium

  • Definition replaced (it previously described the luminal layer) with the expanded definition proposed in the issue [PMID:26552890, PMID:37288662].
  • Logical definition: 'organ component layer' and (part_of some endometrium) and (adjacent_to some myometrium) (was 'endometrium epithelium' and (adjacent_to some 'uterine lumen')).

UBERON:0022356 outer layer of endometrium → functional layer of endometrium

  • Relabelled to "functional layer of endometrium" (this was already an EXACT synonym from FMA:86493). The old label "outer layer of endometrium" is kept as a RELATED synonym, not EXACT, because "outer" is misleading for the layer next to the lumen.
  • Definition replaced with the expanded definition proposed in the issue [PMID:25141152, PMID:26552890, PMID:37288662].
  • Logical definition: 'organ component layer' and (part_of some endometrium) and (adjacent_to some 'uterine lumen') (was 'endometrium epithelium' and (adjacent_to some myometrium)).

Rationale for genus change: both layers contain stroma, glands and blood vessels as well as epithelium, so endometrium epithelium was too narrow a genus.

Both terms also get a term_tracker_item pointing to the issue. I checked that the cited PMIDs exist and are on topic: endometrial stem/progenitor cells, uterine vasculature in the cycle, and cyclic decidualization. Locally, ELK reasoning with --equivalent-classes-allowed asserted-only passed. No other terms reference these two IDs.


🤖 Generated by @ai4c-agent

🤖 Generated with Claude Code

- UBERON:0022355 'basal layer of endometrium': definition and logical
  definition previously described the luminal (functional) layer. Now
  defined as an organ component layer, part of endometrium, adjacent to
  myometrium, with expanded definition [PMID:26552890, PMID:37288662].
- UBERON:0022356: relabelled from 'outer layer of endometrium' to
  'functional layer of endometrium' (old label kept as RELATED synonym).
  Now defined as an organ component layer, part of endometrium, adjacent
  to uterine lumen, with expanded definition [PMID:25141152,
  PMID:26552890, PMID:37288662].
- Genus changed from 'endometrium epithelium' to 'organ component layer',
  since both layers contain stroma, glands and vasculature, not just
  epithelium.
- Added term_tracker_item links to the issue.

Requested by @mkeays in #3803.

---
🤖 **Generated by @ai4c-agent**
- Model: `claude-opus-5-5`
- Agent harness: claude-code
- Triggered by: @mkeays
- Run: [View workflow run](https://github.com/obophenotype/uberon/actions/runs/40682033176)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown
Contributor
This PR modifies some logical definitions. See details below:

Number of classes with modified logical definitions: 2

functional layer of endometrium

No changes in inferred subclasses.

basal layer of endometrium

No changes in inferred subclasses.

As requested by @mkeays on #3803:
- UBERON:0022355 basal layer of endometrium: added EXACT synonyms
  'basalis layer', 'endometrial basal layer', and Latin
  'stratum basale endometrii' (OMO:0003011 latin term).
- UBERON:0022356 functional layer of endometrium: added EXACT synonyms
  'functionalis layer', 'endometrial functional layer', and Latin
  'stratum functionale endometrii' (OMO:0003011 latin term).

---
🤖 **Generated by @ai4c-agent**
- Model: `claude-opus-5-5`
- Agent harness: claude-code
- Triggered by: @mkeays
- Run: [View workflow run](https://github.com/obophenotype/uberon/actions/runs/40684942829)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@ai4c-agent

ai4c-agent Bot commented Oct 28, 2026

Copy link
Copy Markdown
Contributor Author

Added the requested synonyms (all EXACT; the two Latin forms are tagged with the OMO:0003011 latin term synonym type):

  • UBERON:0022355 basal layer of endometrium: "basalis layer", "endometrial basal layer", "stratum basale endometrii"
  • UBERON:0022356 functional layer of endometrium: "functionalis layer", "endometrial functional layer", "stratum functionale endometrii"

🤖 Generated by @ai4c-agent

mkeays and others added 3 commits October 28, 2026 13:04
…trium (#3803)

Add a foaf:depiction to UBERON:0022355 (basal layer of endometrium) and
UBERON:0022356 (functional layer of endometrium), as @mkeays requested. The
image is
https://upload.wikimedia.org/wikipedia/commons/8/87/Cells_of_the_uterus_in_different_menstrual_cycle_stages.png
(Figure 6 of Ong et al. 2026, Sci Adv, PMID:42853913).

Each depiction axiom carries three annotations:
- xref PMID:42853913
- rdfs:comment citing the figure source
- dcterms:license https://creativecommons.org/licenses/by/4.0/

I confirmed the PMID matches the paper and that Wikimedia Commons lists the
file as CC BY 4.0.

---
🤖 **Generated by @ai4c-agent**
- Model: `claude-opus-5-5`
- Agent harness: claude-code
- Triggered by: @mkeays
- Run: [View workflow run](https://github.com/obophenotype/uberon/actions/runs/40716323564)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@mkeays
mkeays marked this pull request as ready for review October 29, 2026 09:54
@mkeays
mkeays requested a review from ct31-sanger October 29, 2026 09:54
@ai4c-reviewer

ai4c-reviewer Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Claude finished @mkeays's task in 39s —— View job


PR review

  • Hierarchy and parents are consistent
  • Definitions and supporting references look adequate
  • Obsolete or replacement handling is safe (no obsoletions)
  • OBO and ODK conventions appear preserved
  • No obvious CI, auth, or workflow regression (only uberon-edit.obo changed)

Summary

  • The swapped definitions and logical definitions are corrected. Basal is now organ component layer and part_of endometrium and adjacent_to myometrium. Functional is now organ component layer and part_of endometrium and adjacent_to uterine lumen. Both match the anatomy, and the genus change away from "endometrium epithelium" is justified because both layers also contain stroma, glands and vessels.
  • The definitions are mirrored by the logical axioms and cite PMIDs. I did not re-fetch the PMIDs myself. The PR description says they were checked.
  • The relabel keeps the old "outer layer of endometrium" as a RELATED synonym, which is sensible because it is misleading. The Latin synonyms use the OMO:0003011 type, which is declared in the file header.
  • term_tracker_item links to definitions of endometrium layers are the wrong way round #3803.
  • The bot's #gogoeditdiff run reports no changes in inferred subclasses.

🔵 SUGGESTION: The branch is 1 commit behind master. Update it and comment #gogoeditdiff again before merging.

I submitted an APPROVE review.

@ai4c-reviewer ai4c-reviewer Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checklist: all five items checked (see details in the Claude comment). Only suggestion: update branch from master and re-run #gogoeditdiff.

@ct31-sanger

Copy link
Copy Markdown
Collaborator

#gogoeditdiff

@github-actions

Copy link
Copy Markdown
Contributor

ROBOT diff report for e5d6ffa

Here's a diff of how these changes impact the classified ontology (on -base file)

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/uberon/uberon-base.owl
  • Version IRI: http://purl.obolibrary.org/obo/uberon/releases/2026-10-29/uberon-base.owl
  • Loaded from: file:/__w/uberon/uberon/master-base/uberon-base.owl

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/uberon/uberon-base.owl
  • Version IRI: http://purl.obolibrary.org/obo/uberon/releases/2026-10-29/uberon-base.owl
  • Loaded from: file:/__w/uberon/uberon/pr-base/uberon-base.owl

Ontology imports

Ontology annotations

basal layer of endometrium http://purl.obolibrary.org/obo/UBERON_0022355

Removed

Added

functional layer of endometrium http://purl.obolibrary.org/obo/UBERON_0022356

Removed

Added

Here's a diff of your edit file (unreasoned)

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/uberon/core.owl
  • Version IRI: None
  • Loaded from: file:/__w/uberon/uberon/master/src/ontology/uberon-edit.obo

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/uberon/core.owl
  • Version IRI: None
  • Loaded from: file:/__w/uberon/uberon/branch/src/ontology/uberon-edit.obo

Ontology imports

Ontology annotations

basal layer of endometrium http://purl.obolibrary.org/obo/UBERON_0022355

Removed

Added

functional layer of endometrium http://purl.obolibrary.org/obo/UBERON_0022356

Removed

Added

Generated by workflow run.

@ct31-sanger ct31-sanger left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@dosumis

dosumis commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

Looks great. Please go ahead and merge.

@dosumis
dosumis merged commit c1116ac into master Oct 29, 2026
9 checks passed
@dosumis
dosumis deleted the ai4c-agent-issue-3803-run2160 branch October 29, 2026 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

definitions of endometrium layers are the wrong way round

3 participants