Repository navigation
Conversation
thswlsqls
marked this pull request as ready for review
October 13, 2026 04:27
Pull request dashboard statusWaiting on reviewers · refreshed 2026-10-13 04:54 UTC Review the latest changes. Non-blocking check failure: codecov/patch Status above doesn't look right?
|
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (75.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #8941 +/- ##
=========================================
Coverage 90.65% 90.65%
- Complexity 10887 10889 +2
=========================================
Files 1015 1015
Lines 29731 29738 +7
Branches 3876 3878 +2
=========================================
+ Hits 26953 26960 +7
- Misses 1860 1861 +1
+ Partials 918 917 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #8745
Description
EndpointUtil.validateEndpointaccepts valid DNS names thatjava.net.URIdoes not parse as a host (JDK-8188305), such ashttp://otlp.1234-ns:4318.ExporterInstrumentation.extractServerAttributesgets a null host and port-1, so with internal telemetry versionLATESTthe exporter metrics omitserver.addressand recordserver.port=80instead of4318.URI.getHost()is null, host and port are now read fromURI.toURL(), like the fallback inEndpointUtil.hasHost. Scheme default ports are unchanged.Testing done
ExporterInstrumentationTest#serverAttributesHostNotParsedByUriforhttp://otlp.1234-ns:4318/v1/traces(port 4318) andhttps://otlp.1234-ns/v1/traces(port 443).Expected attributes to have <2> entries but actually has <1>)../gradlew :exporters:common:checkpassed. No apidiff change (internal package).