Repository navigation
Conversation
thswlsqls
marked this pull request as ready for review
October 13, 2026 05:32
Pull request dashboard statusWaiting on reviewers · refreshed 2026-10-13 05:58 UTC Review the latest changes. Status above doesn't look right?
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8944 +/- ##
============================================
+ Coverage 90.65% 90.66% +0.01%
- Complexity 10887 10890 +3
============================================
Files 1015 1015
Lines 29731 29734 +3
Branches 3876 3877 +1
============================================
+ Hits 26953 26959 +6
Misses 1860 1860
+ Partials 918 915 -3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8942
Description
SystemOutLogRecordExporter.formatLog()printed1970-01-01T00:00:00Zfor any log record emitted withoutsetTimestamp(...), because it only readgetTimestampEpochNanos(), which is 0 in that case.Timestampis 0, following the logs data model guidance for single-timestamp formats: "UseTimestampif it is present, otherwise useObservedTimestamp."EventToSpanEventBridge(sdk-extensions/incubator) uses the same fallback.Testing done
SystemOutLogRecordExporterTest#formatWithoutTimestampUsesObservedTimestamp(timestamp unset, observed timestamp set). With the fix reverted it fails: expected1970-08-07T10:00:00Z ...but was1970-01-01T00:00:00Z ....format()andformatWithEventName()set a timestamp and leave the observed timestamp at 0; they still pass, soTimestampkeeps priority../gradlew :exporters:logging:checkpassed (17 tests). No apidiff change:formatLogis package-private.