Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/agents/extensions/models/litellm_model.py
Original file line number Diff line number Diff line change
Expand Up @@ -614,9 +614,9 @@ async def _fetch_response(
stream_options = {"include_usage": model_settings.include_usage}

extra_kwargs: dict[str, Any] = {}
if model_settings.extra_query:
if model_settings.extra_query is not None:
extra_kwargs["extra_query"] = copy(model_settings.extra_query)
if model_settings.metadata:
if model_settings.metadata is not None:
extra_kwargs["metadata"] = copy(model_settings.metadata)
if model_settings.extra_body is not None:
extra_body = copy(model_settings.extra_body)
Expand Down
37 changes: 37 additions & 0 deletions tests/models/test_litellm_extra_body.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,43 @@ def __bool__(self) -> bool:
assert model._get_reasoning_effort(settings) == "low"


@pytest.mark.allow_call_model_methods
@pytest.mark.asyncio
async def test_empty_extra_query_and_metadata_are_forwarded(monkeypatch):
"""
Forward empty `extra_query` and `metadata` dicts instead of dropping them.

The OpenAI and AnyLLM model paths forward these settings whenever they are
not `None`; the falsy check here dropped `{}`, silently discarding an
explicitly configured value and diverging from those paths.
"""
captured: dict[str, object] = {}

async def fake_acompletion(model, messages=None, **kwargs):
captured.update(kwargs)
msg = Message(role="assistant", content="ok")
choice = Choices(index=0, message=msg)
return ModelResponse(choices=[choice], usage=Usage(0, 0, 0))

monkeypatch.setattr(litellm, "acompletion", fake_acompletion)
settings = ModelSettings(extra_query={}, metadata={})
model = LitellmModel(model="test-model")

await model.get_response(
system_instructions=None,
input=[],
model_settings=settings,
tools=[],
output_schema=None,
handoffs=[],
tracing=ModelTracing.DISABLED,
previous_response_id=None,
)

assert captured["extra_query"] == {}
assert captured["metadata"] == {}


@pytest.mark.allow_call_model_methods
@pytest.mark.asyncio
async def test_extra_body_is_forwarded(monkeypatch):
Expand Down
Loading