fix(core): strict_schema error message, REPL whitespace input, debug docstrings - #4600
Merged
seratch merged 1 commit intoAug 23, 2026
Merged
Conversation
…g docstrings - strict_schema: 'Expected ... to resolved to a dictionary' -> 'to resolve' (two occurrences) - repl: skip whitespace-only input; only truly empty strings were skipped, so a line of spaces was sent to the model as a blank message - _debug: DONT_LOG_MODEL_DATA/DONT_LOG_TOOL_DATA docstrings said 'Set this flag to enable logging' — the flags are opt-out and default to True; logging is enabled by setting the env var to 0/false, as docs/config.md documents
seratch
approved these changes
Aug 23, 2026
seratch
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three small, independent fixes:
strict_schema.py: twoValueErrormessages say "Expected$ref: …to resolved to a dictionary" — fixed to "to resolve to". No tests assert on this text.repl.py: the exit check strips input but the emptiness check doesn't, so a whitespace-only line was appended as a blank user message and sent to the model.tests/test_repl.py::test_run_demo_loop_skips_empty_inputonly feeds"", so intent is to skip blank lines generally. Now skips whitespace-only input._debug.py:DONT_LOG_MODEL_DATA/DONT_LOG_TOOL_DATAdocstrings said "Set this flag to enable logging them" — inverted. These flags are opt-out and default toTrue; logging is enabled by setting the env var to0/falsebefore startup, which is whatdocs/config.md("Sensitive data in logs") documents.