gRIBI WCMP Group Resizing and Weight Changes

[ghost]

System Test Plan see for more info: b/540867412

• Objective: Test the switch's ability to handle dynamic changes to Weighted Cost Multi-Path (WCMP) groups programmed via gRIBI. This simulates Orion adjusting tunnel allocations. Specifically validates gRIBI Modify (REPLACE) operations to adjust weights of NextHops within an active NextHopGroup.
  • Interfaces Used: gRIBI, gNMI
  • Expected Outcome Summary:
    • Verify initial traffic distribution across WCMP members matches the weights.
    • Adding, removing, or changing weights of NextHops within the NextHopGroup results in traffic distribution adjusting accordingly.
    • All changes are hitless for unaffected flows.
    • gNMI AFT telemetry via /network-instances/network-instance/afts/next-hop-groups/next-hop-group/state/ reflects the NHG changes.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new system test plan (TE-3.10) designed to verify the switch's capability to dynamically manage WCMP groups using gRIBI. The changes include the necessary documentation and metadata to support this test, which focuses on hitless weight adjustments and group resizing while maintaining traffic integrity for background flows.

Highlights

• New Test Case Implementation: Added a new test suite, TE-3.10, to validate dynamic Weighted Cost Multi-Path (WCMP) group resizing and weight modifications via gRIBI.
• Test Coverage: The new test covers weight updates, dynamic addition/removal of NextHops, and negative test cases to ensure robust gRIBI operation handling.
• Test Registry Update: Registered the new TE-3.10 test case in the global test registry to ensure inclusion in the automated test pipeline.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[OpenConfigBot]

Pull Request Functional Test Report for #5992 / c9281a1

Virtual Devices

Device	Test	Test Documentation	Job	Raw Log
Arista cEOS		TE-3.10: gRIBI WCMP Group Resizing and Weight Changes	19577fbd	Log
Cisco 8000E		TE-3.10: gRIBI WCMP Group Resizing and Weight Changes	628d4228	Log
Cisco XRd		TE-3.10: gRIBI WCMP Group Resizing and Weight Changes	7205b201	Log
Juniper ncPTX		TE-3.10: gRIBI WCMP Group Resizing and Weight Changes	60206658	Log
Nokia SR Linux		TE-3.10: gRIBI WCMP Group Resizing and Weight Changes	1c4f262c	Log
Openconfig Lemming		TE-3.10: gRIBI WCMP Group Resizing and Weight Changes	50077169	Log

Hardware Devices

Device	Test	Test Documentation	Raw Log
Arista		TE-3.10: gRIBI WCMP Group Resizing and Weight Changes
Cisco		TE-3.10: gRIBI WCMP Group Resizing and Weight Changes
Juniper		TE-3.10: gRIBI WCMP Group Resizing and Weight Changes
Nokia		TE-3.10: gRIBI WCMP Group Resizing and Weight Changes

Help

[gemini-code-assist]

Code Review

This pull request introduces a new test plan (TE-3.10) for validating gRIBI WCMP group resizing and dynamic weight changes, including the README test plan, metadata, and registry entry. The review feedback correctly points out that the test plan uses the disallowed private IPv4 range 10.0.0.0/16, which violates the repository's network assignment guidelines. It is recommended to update these references to use allowed IP blocks such as 198.18.0.0/16.

[AmrNJ]

LGTM.