ADD: Liese filter - #162
Merged
Merged
Conversation
Adds filter_type="leise" alongside the existing Savitzky-Golay filter in both the scipy and tensorflow wind retrieval engines. The Leise path uses an iterated 5-point kernel ([-1/16, 1/4, 5/8, 1/4, -1/16]) with mirror boundaries via scipy.ndimage.convolve1d, controlled by a new leise_nstep kwarg. Default filter_type="savgol" preserves existing behavior. Refactored the duplicated 9-line filter blocks in both engines into a shared _apply_low_pass_filter helper. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #162 +/- ##
==========================================
- Coverage 70.38% 70.28% -0.11%
==========================================
Files 32 32
Lines 5315 5313 -2
==========================================
- Hits 3741 3734 -7
- Misses 1574 1579 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
One test failed due to IEM hangup (unrelated to PR), another fledging on conda download. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds the liese filter, encoded in Python, that was present in the original MultiDop package as an option.