OCPBUGS-112348: Increase TC-74751 Eventually timeout for vSphere OVA upload

[jira-solve-bot]

- What I did

Increased the Eventually timeout at mco_bootimages.go:409 from 2 minutes to 10 minutes. This poll waits for BootImageUpdateProgressing to become False after fixing the arch annotation on a cloned MachineSet. On vSphere, the controller must upload an OVA template before reconciliation completes, which routinely exceeds the previous 2-minute timeout and causes intermittent failures in the e2e-vsphere-mco-bootimages job.

Non-vSphere platforms satisfy the condition quickly, so Eventually returns early and the longer cap has no effect there.

Fixes: https://redhat.atlassian.net/browse/OCPBUGS-112348

- How to verify it

1. Run the e2e-vsphere-mco-bootimages CI job and confirm TC-74751 no longer times out during OVA upload.
2. Verify that non-vSphere platforms (e.g., AWS, GCP) are unaffected — the test should still pass and return early.

- Description for the changelog

Increase TC-74751 Eventually timeout to 10 minutes to accommodate vSphere OVA upload latency.

---

Always review AI generated responses prior to use.
AI-assisted response via openshift-developer plugin

---

Note: This PR was auto-generated by the jira-agent periodic CI job in response to OCPBUGS-112348. See the full report for token usage, cost breakdown, and detailed phase output.

Summary by CodeRabbit

• Tests
  • Increased the allowed wait time for boot image update completion checks from 2 minutes to 10 minutes.
  • Improved alignment in test setup configuration.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci-robot]

@jira-solve-bot: This pull request references Jira Issue OCPBUGS-112348, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.1.0) matches configured target version for branch (5.1.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

- What I did

Increased the Eventually timeout at mco_bootimages.go:409 from 2 minutes to 10 minutes. This poll waits for BootImageUpdateProgressing to become False after fixing the arch annotation on a cloned MachineSet. On vSphere, the controller must upload an OVA template before reconciliation completes, which routinely exceeds the previous 2-minute timeout and causes intermittent failures in the e2e-vsphere-mco-bootimages job.

Non-vSphere platforms satisfy the condition quickly, so Eventually returns early and the longer cap has no effect there.

Fixes: https://redhat.atlassian.net/browse/OCPBUGS-112348

- How to verify it

1. Run the e2e-vsphere-mco-bootimages CI job and confirm TC-74751 no longer times out during OVA upload.
2. Verify that non-vSphere platforms (e.g., AWS, GCP) are unaffected — the test should still pass and return early.

- Description for the changelog

Increase TC-74751 Eventually timeout to 10 minutes to accommodate vSphere OVA upload latency.

---

Always review AI generated responses prior to use.
AI-assisted response via openshift-developer plugin

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: a13bb6a3-b7e0-4759-ae4d-a80184c98213

📥 Commits

Reviewing files that changed from the base of the PR and between 8f1ab28 and bda25da.

📒 Files selected for processing (1)

• test/extended-priv/mco_bootimages.go

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.

---

Walkthrough

The pull request updates variable alignment in two boot image test setup blocks and increases the BootImageUpdateProgressing=False assertion timeout from 2 minutes to 10 minutes.

Changes

Boot image extended-privilege tests

Layer / File(s)	Summary
Align boot image test declarations test/extended-priv/mco_bootimages.go	Aligns variable declarations in two test setup blocks without changing behavior.
Extend boot image progress wait test/extended-priv/mco_bootimages.go	Increases the wait for BootImageUpdateProgressing to become false from 2 minutes to 10 minutes.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to bda25

This change only extends a test timeout for vSphere OVA uploads while allowing faster platforms to return early; no actionable merge-blocking risk remains after normal checks and review.

Suggested reviewers: djoshy, sergiordlr

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PASS. The pull request changes only variable alignment and the Eventually timeout at line 409. The diff contains no changes to It, Describe, Context, or When titles. The file's existing titl…
Test Structure And Quality	✅ Passed	PASS. The pull request changes only formatting and the TC-74751 wait from 2m to 10m. The affected Eventually call has an explicit timeout, a 10s polling interval, and a meaningful failure message. T…
Microshift Test Compatibility	✅ Passed	PASS — The pull request does not add a new Ginkgo test. The diff only changes variable alignment and increases an existing Eventually timeout from 2m to 10m inside the pre-existing `[PolarionID:…
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PASS: The pull request adds no new Ginkgo tests. The base and head revisions contain the same Describe and It declarations, including [PolarionID:74751]. The diff only changes variable alignment…
Topology-Aware Scheduling Compatibility	✅ Passed	PASS: The pull request changes only test/extended-priv/mco_bootimages.go. The functional change increases a test Eventually timeout from 2m to 10m; the other changes only align local variable …
Ote Binary Stdout Contract	✅ Passed	PASS. The commit changes only variable alignment and the Eventually timeout from 2m to 10m in test/extended-priv/mco_bootimages.go. It adds no stdout write, logging configuration, or process-l…
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PASS — The pull request does not add a Ginkgo test. The base and head revisions contain the same Describe and It declarations. The only behavioral change is the existing TC-74751 Eventually time…
No-Weak-Crypto	✅ Passed	PASS: The pull request changes only variable alignment and the Eventually timeout from "2m" to "10m" in test/extended-priv/mco_bootimages.go. The exact diff adds no MD5, SHA1, DES, RC4, 3DES, …
Container-Privileges	✅ Passed	PASS. The pull request changes only test/extended-priv/mco_bootimages.go. Added lines adjust Go variable alignment and increase an Eventually timeout from 2m to 10m. No added line contains pri…
No-Sensitive-Data-In-Logs	✅ Passed	PASS: The pull request changes only variable alignment and the Eventually timeout from 2m to 10m. It adds no logging, printing, or diagnostic data. Existing PrettyString() failure text and log…
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies the timeout increase and the vSphere OVA upload context. It matches the main change in the pull request.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files.

Full details: Stable And Deterministic Test Names

Explanation

PASS. The pull request changes only variable alignment and the Eventually timeout at line 409. The diff contains no changes to It, Describe, Context, or When titles. The file's existing titles are static and contain no generated names, timestamps, UUIDs, node names, namespaces, or IP addresses.

Full details: Test Structure And Quality

Explanation

PASS. The pull request changes only formatting and the TC-74751 wait from 2m to 10m. The affected Eventually call has an explicit timeout, a 10s polling interval, and a meaningful failure message. The surrounding test uses JustBeforeEach/DeferCleanup for shared setup and cleanup, and the cloned MachineSet has deferred cleanup. Other cluster waits in the test also have explicit timeouts. The 10m duration follows existing long-running test patterns and addresses the stated vSphere upload latency. No new single-responsibility, cleanup, timeout, assertion-message, or consistency issue is introduced.

Full details: Microshift Test Compatibility

Explanation

PASS — The pull request does not add a new Ginkgo test. The diff only changes variable alignment and increases an existing Eventually timeout from 2m to 10m inside the pre-existing [PolarionID:74751] test. Although that existing test uses MachineSet, the custom check applies to newly added tests, and unchanged behavior cannot establish pull-request causality.

Full details: Single Node Openshift (Sno) Test Compatibility

Explanation

PASS: The pull request adds no new Ginkgo tests. The base and head revisions contain the same Describe and It declarations, including [PolarionID:74751]. The diff only changes variable alignment and the existing Eventually timeout from 2m to 10m, so the SNO multi-node test check is not applicable.

Full details: Topology-Aware Scheduling Compatibility

Explanation

PASS: The pull request changes only test/extended-priv/mco_bootimages.go. The functional change increases a test Eventually timeout from 2m to 10m; the other changes only align local variable declarations. No deployment manifest, operator code, controller code, replica setting, affinity, topology spread, node selector, toleration, or PDB changed. The topology-aware scheduling check is therefore not applicable.

Full details: Ote Binary Stdout Contract

Explanation

PASS. The commit changes only variable alignment and the Eventually timeout from 2m to 10m in test/extended-priv/mco_bootimages.go. It adds no stdout write, logging configuration, or process-level setup. The file has no main, TestMain, BeforeSuite, AfterSuite, SynchronizedBeforeSuite, or RunSpecs code. Existing logger.Infof calls are unchanged, and logext writes to ginkgo.GinkgoWriter.

Full details: Ipv6 And Disconnected Network Test Compatibility

Explanation

PASS — The pull request does not add a Ginkgo test. The base and head revisions contain the same Describe and It declarations. The only behavioral change is the existing TC-74751 Eventually timeout from 2m to 10m; the other changes only align declarations. No changed code adds IPv4 assumptions or external connectivity requirements.

Full details: No-Weak-Crypto

Explanation

PASS: The pull request changes only variable alignment and the Eventually timeout from "2m" to "10m" in test/extended-priv/mco_bootimages.go. The exact diff adds no MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB, custom crypto, or secret/token comparison logic. Existing crypto/sha256 usage is outside the changed file and is not introduced by this pull request.

Full details: Container-Privileges

Explanation

PASS. The pull request changes only test/extended-priv/mco_bootimages.go. Added lines adjust Go variable alignment and increase an Eventually timeout from 2m to 10m. No added line contains privilege settings, and no Kubernetes or manifest file changed. Existing privileged workloads elsewhere in the repository are unchanged and are not caused by this pull request.

Full details: No-Sensitive-Data-In-Logs

Explanation

PASS: The pull request changes only variable alignment and the Eventually timeout from 2m to 10m. It adds no logging, printing, or diagnostic data. Existing PrettyString() failure text and logger calls remain unchanged, so the patch introduces no sensitive-data exposure in logs.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci-robot]

@jira-solve-bot: This pull request references Jira Issue OCPBUGS-112348, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.1.0) matches configured target version for branch (5.1.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Details

In response to this:

- What I did

Increased the Eventually timeout at mco_bootimages.go:409 from 2 minutes to 10 minutes. This poll waits for BootImageUpdateProgressing to become False after fixing the arch annotation on a cloned MachineSet. On vSphere, the controller must upload an OVA template before reconciliation completes, which routinely exceeds the previous 2-minute timeout and causes intermittent failures in the e2e-vsphere-mco-bootimages job.

Non-vSphere platforms satisfy the condition quickly, so Eventually returns early and the longer cap has no effect there.

Fixes: https://redhat.atlassian.net/browse/OCPBUGS-112348

- How to verify it

1. Run the e2e-vsphere-mco-bootimages CI job and confirm TC-74751 no longer times out during OVA upload.
2. Verify that non-vSphere platforms (e.g., AWS, GCP) are unaffected — the test should still pass and return early.

- Description for the changelog

Increase TC-74751 Eventually timeout to 10 minutes to accommodate vSphere OVA upload latency.

---

Always review AI generated responses prior to use.
AI-assisted response via openshift-developer plugin

---

Note: This PR was auto-generated by the jira-agent periodic CI job in response to OCPBUGS-112348. See the full report for token usage, cost breakdown, and detailed phase output.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@jira-solve-bot: This pull request references Jira Issue OCPBUGS-112348, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.1.0) matches configured target version for branch (5.1.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Details

In response to this:

- What I did

Increased the Eventually timeout at mco_bootimages.go:409 from 2 minutes to 10 minutes. This poll waits for BootImageUpdateProgressing to become False after fixing the arch annotation on a cloned MachineSet. On vSphere, the controller must upload an OVA template before reconciliation completes, which routinely exceeds the previous 2-minute timeout and causes intermittent failures in the e2e-vsphere-mco-bootimages job.

Non-vSphere platforms satisfy the condition quickly, so Eventually returns early and the longer cap has no effect there.

Fixes: https://redhat.atlassian.net/browse/OCPBUGS-112348

- How to verify it

1. Run the e2e-vsphere-mco-bootimages CI job and confirm TC-74751 no longer times out during OVA upload.
2. Verify that non-vSphere platforms (e.g., AWS, GCP) are unaffected — the test should still pass and return early.

- Description for the changelog

Increase TC-74751 Eventually timeout to 10 minutes to accommodate vSphere OVA upload latency.

---

Always review AI generated responses prior to use.
AI-assisted response via openshift-developer plugin

---

Note: This PR was auto-generated by the jira-agent periodic CI job in response to OCPBUGS-112348. See the full report for token usage, cost breakdown, and detailed phase output.

Summary by CodeRabbit

• Tests
• Increased the allowed wait time for boot image update completion checks from 2 minutes to 10 minutes.
• Improved alignment in test setup configuration.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[djoshy]

/lgtm

/verified by e2es

[openshift-ci-robot]

@djoshy: This PR has been marked as verified by e2es.

Details

In response to this:

/lgtm

/verified by e2es

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-merge-bot]

Pipeline controller notification

No second-stage tests were triggered for this PR.

This can happen when:

• The changed files don't match any pipeline_run_if_changed patterns
• All files match pipeline_skip_if_only_changed patterns
• No pipeline-controlled jobs are defined for the main branch

Use /test ? to see all available tests.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: djoshy, jira-solve-bot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [djoshy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[djoshy]

/retest-required

[djoshy]

/cherry-pick release-5.0 release-4.22

[openshift-cherrypick-robot]

@djoshy: once the present PR merges, I will cherry-pick it on top of release-5.0 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-5.0 release-4.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[djoshy]

/retest-required

[openshift-ci]

@jira-solve-bot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

@jira-solve-bot: Jira Issue Verification Checks: Jira Issue OCPBUGS-112348
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-112348 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

- What I did

Increased the Eventually timeout at mco_bootimages.go:409 from 2 minutes to 10 minutes. This poll waits for BootImageUpdateProgressing to become False after fixing the arch annotation on a cloned MachineSet. On vSphere, the controller must upload an OVA template before reconciliation completes, which routinely exceeds the previous 2-minute timeout and causes intermittent failures in the e2e-vsphere-mco-bootimages job.

Non-vSphere platforms satisfy the condition quickly, so Eventually returns early and the longer cap has no effect there.

Fixes: https://redhat.atlassian.net/browse/OCPBUGS-112348

- How to verify it

1. Run the e2e-vsphere-mco-bootimages CI job and confirm TC-74751 no longer times out during OVA upload.
2. Verify that non-vSphere platforms (e.g., AWS, GCP) are unaffected — the test should still pass and return early.

- Description for the changelog

Increase TC-74751 Eventually timeout to 10 minutes to accommodate vSphere OVA upload latency.

---

Always review AI generated responses prior to use.
AI-assisted response via openshift-developer plugin

---

Note: This PR was auto-generated by the jira-agent periodic CI job in response to OCPBUGS-112348. See the full report for token usage, cost breakdown, and detailed phase output.

Summary by CodeRabbit

• Tests
• Increased the allowed wait time for boot image update completion checks from 2 minutes to 10 minutes.
• Improved alignment in test setup configuration.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-cherrypick-robot]

@djoshy: new pull request created: #6491

Details

In response to this:

/cherry-pick release-5.0 release-4.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-merge-robot]

Fix included in release 5.1.0-0.nightly-2026-09-03-014242