USHIFT-7337: Make CentOS / RHEL optional scenarios consistent across OS versions and build types by ggiguash · Pull Request #7032 · openshift/microshift

ggiguash · 2026-07-10T05:45:47Z

Using the same options / logic for optional CentOS scenarios, like we do for RHEL.
Making all optional scenarios consistent across all OS

Summary by CodeRabbit

Bug Fixes
- Improved optional ARM VM test reliability by conditionally selecting SR-IOV–appropriate networking and adjusting which checks are skipped per architecture.
- Updated optional VM launches to include the intended vCPU allocation.
Tests
- Added retry-based cluster DNS verification to confirm DNS resolution after custom DNS resource changes.
Chores
- Extended optional-suite execution and Greenboot timeouts to better accommodate longer optional package startup/restart cycles.

openshift-ci · 2026-07-10T05:45:50Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

openshift-ci-robot · 2026-07-10T05:45:50Z

@ggiguash: This pull request references USHIFT-7337 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2026-07-10T05:46:06Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggiguash

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [ggiguash]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

coderabbitai · 2026-07-10T05:46:11Z

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

@coderabbitai resume to resume automatic reviews.
@coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

▶️ Resume reviews
🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 9e985a9d-3bee-454b-bb31-673e2617a87c

📥 Commits

Reviewing files that changed from the base of the PR and between ed2337f and d7d7042.

📒 Files selected for processing (9)

test/scenarios-bootc/el10/periodics/el102-src@optional.sh
test/scenarios-bootc/el10/releases/el102-lrel@optional.sh
test/scenarios-bootc/el9/periodics/el98-src@optional.sh
test/scenarios-bootc/el9/releases/el98-lrel@optional.sh
test/scenarios-bootc/upstream/cos10-src@optional.sh
test/scenarios-bootc/upstream/cos9-src@optional.sh
test/scenarios/periodics/el98-src@optional.sh
test/scenarios/releases/el98-lrel@optional.sh
test/suites/configuration1/dns-resource-configuration.robot

✅ Files skipped from review due to trivial changes (1)

test/scenarios/periodics/el98-src@optional.sh

🚧 Files skipped from review as they are similar to previous changes (7)

test/scenarios/releases/el98-lrel@optional.sh
test/scenarios-bootc/el10/releases/el102-lrel@optional.sh
test/suites/configuration1/dns-resource-configuration.robot
test/scenarios-bootc/el10/periodics/el102-src@optional.sh
test/scenarios-bootc/upstream/cos10-src@optional.sh
test/scenarios-bootc/el9/releases/el98-lrel@optional.sh
test/scenarios-bootc/el9/periodics/el98-src@optional.sh

Walkthrough

Optional Bootc scenarios now allow additional restart time, select VM networks by architecture, adjust test skips, and configure VM CPU counts. The DNS configuration suite now retries DNS resolution after resource changes.

Changes

Optional scenario and DNS test updates

Layer / File(s)	Summary
Optional scenario runtime configuration `test/scenarios-bootc/el10/periodics/el102-src@optional.sh`, `test/scenarios-bootc/el10/releases/el102-lrel@optional.sh`, `test/scenarios-bootc/el9/periodics/el98-src@optional.sh`, `test/scenarios-bootc/el9/releases/el98-lrel@optional.sh`, `test/scenarios/releases/el98-lrel@optional.sh`, `test/scenarios/periodics/el98-src@optional.sh`, `test/scenarios-bootc/upstream/cos9-src@optional.sh`, `test/scenarios-bootc/upstream/cos10-src@optional.sh`	Optional scenarios set extended execution or Greenboot timeouts; Cos9 and Cos10 derive networking-related values as described in their scripts.
Architecture-specific VM setup `test/scenarios-bootc/el10/periodics/el102-src@optional.sh`, `test/scenarios-bootc/el9/periodics/el98-src@optional.sh`, `test/scenarios-bootc/upstream/cos9-src@optional.sh`, `test/scenarios-bootc/upstream/cos10-src@optional.sh`	VM launches use four vCPUs, and network lists omit `sriov` on `aarch64`.
Optional test selection `test/scenarios-bootc/el9/periodics/el98-src@optional.sh`, `test/scenarios-bootc/upstream/cos9-src@optional.sh`, `test/scenarios-bootc/upstream/cos10-src@optional.sh`	Optional test skips vary by architecture; Cos10 also skips `generic-device-plugin`.
Retryable DNS resource validation `test/suites/configuration1/dns-resource-configuration.robot`	The DNS resource-change test uses reusable keywords that retry `nslookup` through `router-default` and verify the requested hostname.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Suggested reviewers: kasturinarra, pacevedom, pmtk, vimauro

🚥 Pre-merge checks | ✅ 14 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (14 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main change: aligning optional CentOS/RHEL scenarios across OS versions and build types.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	No Ginkgo-style test titles were added or changed; the touched files are shell scenarios and a Robot suite with static, deterministic names.
Test Structure And Quality	✅ Passed	PASS: The PR only changes shell scripts and one Robot suite; no Ginkgo It/BeforeEach/Eventually code was added or modified, so this check is not applicable.
Microshift Test Compatibility	✅ Passed	No new Ginkgo tests were added; the diff is shell scenario logic and a Robot suite, with no blocked MicroShift APIs or unsupported namespaces.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	No new or changed Ginkgo e2e tests; the diff only updates bash scenario scripts and a Robot Framework suite, with no SNO-sensitive test code.
Topology-Aware Scheduling Compatibility	✅ Passed	Only test scenario scripts and a Robot suite changed; no manifests/controllers or scheduling constraints like affinity, nodeSelector, or PDBs were introduced.
Ote Binary Stdout Contract	✅ Passed	No stdout-writing process-level code was added; the PR only changes shell scenario scripts and a Robot suite, with no stdout prints/logging setup.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	No new Ginkgo e2e tests were added; the new Robot test uses cluster-local DNS, and the shell changes don’t add public-internet or IPv4-only assumptions.
No-Weak-Crypto	✅ Passed	No weak-crypto primitives, custom crypto, or secret/token comparisons appear in the touched files; changes are scenario timeouts, networking, and DNS lookup keywords only.
Container-Privileges	✅ Passed	The PR only changes a shell scenario script; no container/K8s manifest adds privileged, hostPID/hostNetwork, allowPrivilegeEscalation, or CAP_SYS_ADMIN.
No-Sensitive-Data-In-Logs	✅ Passed	No added logging of secrets/PII/internal hostnames; changes only adjust scenario args/timeouts and a DNS assertion test.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

ggiguash · 2026-07-10T05:48:06Z

/test ?

ggiguash · 2026-07-10T05:49:08Z