OCPBUGS-99536: Raise status polling timeout and write bound

[jcmoraisjr]

The 3-replica conflicting router stress test was intermittently failing in two independent places.

1. Polling timeout 2m -> 5m: the leader election lease lasts 1 minute. Under normal conditions all route statuses are written within 1-2 lease cycles, which fit in the previous 2-minute timeout. Under heavier contention a router replica may need to re-acquire the lease 3 or more times until all routes are updated.

2. Write upper bound 50 -> 75: the per-route contention detector runs asynchronously and can lag behind update events, allowing a few extra writes before suppressing further updates. The previous limit of 50 caused intermittent failures; 75 is a more conservative ceiling.

https://redhat.atlassian.net/browse/OCPBUGS-99536

Summary by CodeRabbit

• Tests
  • Extended the conflicting-router convergence test timeout to accommodate asynchronous status updates.
  • Increased the permitted number of status updates for more reliable stress-test validation.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

[openshift-ci-robot]

@jcmoraisjr: This pull request references Jira Issue OCPBUGS-99536, which is invalid:

• expected the bug to target the "5.1.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

The 3-replica conflicting router stress test was intermittently failing in two independent places.

1. Polling timeout 2m -> 5m: the leader election lease lasts 1 minute. Under normal conditions all route statuses are written within 1-2 lease cycles, which fit in the previous 2-minute timeout. Under heavier contention a router replica may need to re-acquire the lease 3 or more times until all routes are updated.

2. Write upper bound 50 -> 75: the per-route contention detector runs asynchronously and can lag behind update events, allowing a few extra writes before suppressing further updates. The previous limit of 50 caused intermittent failures; 75 is a more conservative ceiling.

https://redhat.atlassian.net/browse/OCPBUGS-99536

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 904868a5-11d6-4ab3-b7c3-0193c69b08be

📥 Commits

Reviewing files that changed from the base of the PR and between fc3000c and 2aa4426.

📒 Files selected for processing (1)

• test/extended/router/stress.go

Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.

---

Walkthrough

The conflicting-router convergence test now waits up to five minutes and allows up to 75 route-status writes. Comments document delays caused by lease reacquisition and asynchronous contention detection.

Changes

Router convergence test

Layer / File(s)	Summary
Adjust convergence tolerance test/extended/router/stress.go	The convergence poll timeout increased from two to five minutes. The permitted route-status writes increased from 50 to 75 while retaining at least one write per route. Comments document contention-related delays.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Merge Risk: ⚪ Minimal · up to 2aa44

This localized test-only change is merge-ready after normal repository checks and review; no actionable merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly summarizes the test changes: a longer status polling timeout and a higher write bound.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The diff changes only polling and write bounds plus comments; all stress.go Ginkgo titles remain unchanged static string literals.
Test Structure And Quality	✅ Passed	The diff only extends an existing bounded wait.Poll to 5 minutes and raises a write assertion bound; the test already uses BeforeEach/AfterEach and namespace-scoped resources.
Microshift Test Compatibility	✅ Passed	The PR modifies an existing router test only: it changes polling and write limits. It adds no Ginkgo test or unavailable API; the test uses the allowed Route API.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The diff only changes timing, comments, and the write bound in an existing Ginkgo test; it adds no new e2e test for this SNO check.
Topology-Aware Scheduling Compatibility	✅ Passed	The commit changes only test/extended/router/stress.go, increasing polling and write-count limits; it adds no deployment, operator, controller, or scheduling constraints.
Ote Binary Stdout Contract	✅ Passed	The diff changes only a Poll timeout, a numeric assertion bound, and comments inside an existing Ginkgo It block; it adds no process-level stdout or logging write.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The diff adds no Ginkgo test; it only changes timing and write bounds in an existing cluster API test, with no IPv4 literals or external endpoints.
No-Weak-Crypto	✅ Passed	The diff changes only polling timeout, comments, and the write bound; it adds no MD5/SHA1/DES/RC4/Blowfish/ECB use, custom crypto, or secret comparison.
Container-Privileges	✅ Passed	HEAD^→HEAD changes only polling, comments, and write bounds; no privilege fields were added. Existing AllowPrivilegeEscalation:true is unchanged.
No-Sensitive-Data-In-Logs	✅ Passed	The diff changes only a polling timeout, a write threshold, and comments; it adds no logging or sensitive-data output.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[jcmoraisjr]

/jira refresh

[openshift-ci-robot]

@jcmoraisjr: This pull request references Jira Issue OCPBUGS-99536, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.1.0) matches configured target version for branch (5.1.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @melvinjoseph86

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@jcmoraisjr: This pull request references Jira Issue OCPBUGS-99536, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.1.0) matches configured target version for branch (5.1.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @melvinjoseph86

Details

In response to this:

The 3-replica conflicting router stress test was intermittently failing in two independent places.

1. Polling timeout 2m -> 5m: the leader election lease lasts 1 minute. Under normal conditions all route statuses are written within 1-2 lease cycles, which fit in the previous 2-minute timeout. Under heavier contention a router replica may need to re-acquire the lease 3 or more times until all routes are updated.

2. Write upper bound 50 -> 75: the per-route contention detector runs asynchronously and can lag behind update events, allowing a few extra writes before suppressing further updates. The previous limit of 50 caused intermittent failures; 75 is a more conservative ceiling.

https://redhat.atlassian.net/browse/OCPBUGS-99536

Summary by CodeRabbit

• Tests
• Extended the conflicting-router convergence test timeout to accommodate asynchronous status updates.
• Increased the permitted number of status updates for more reliable stress-test validation.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-merge-bot]

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

[bentito]

/assign @gcs278

[bentito]

/assign @bentito

[gcs278]

We discussed extensively in slack - I think this is a reasonable move. We are still testing against infinite status writes loops, and eventual successful route status - just loosening the parameters given the edge cases we discussed.

/lgtm

@bentito want to take a quick look and see if you agree?
/hold

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gcs278, jcmoraisjr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• test/extended/router/OWNERS [gcs278,jcmoraisjr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[bentito]

We discussed extensively in slack - I think this is a reasonable move. We are still testing against infinite status writes loops, and eventual successful route status - just loosening the parameters given the edge cases we discussed.

/lgtm

@bentito want to take a quick look and see if you agree? /hold

yeah I think the changes are reasonable
/unhold

[jcmoraisjr]

Increasing timeout and threshold to avoid flakiness on some edge cases. Marking it as verified.

/verified by CI

[openshift-ci-robot]

@jcmoraisjr: This PR has been marked as verified by CI.

Details

In response to this:

Increasing timeout and threshold to avoid flakiness on some edge cases. Marking it as verified.

/verified by CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-merge-bot]

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

[openshift-ci]

@jcmoraisjr: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.