OCPBUGS-86257: Fix pathological events

[gnufied]

Fixes https://redhat.atlassian.net/browse/OCPBUGS-86257

Summary by CodeRabbit

• Bug Fixes
  • Improved VMware vSphere event matching by using the latest occurrence when evaluating overlapping events.
  • Added support for matching scaling-related rollout events.
  • Refined event message matching for greater accuracy.
• Tests
  • Added coverage for valid rollout events, out-of-window events, unrelated scaling events, and events with differing first and last occurrences.

[openshift-ci-robot]

@gnufied: This pull request references Jira Issue OCPBUGS-86257, which is invalid:

• expected the bug to target the "5.1.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Fixes https://redhat.atlassian.net/browse/OCPBUGS-86257

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 4fe9f9f9-d5d8-4f15-802e-b6ff78c00968

📥 Commits

Reviewing files that changed from the base of the PR and between dbd1161 and ae4038e.

📒 Files selected for processing (2)

• pkg/monitortestlibrary/pathologicaleventlibrary/duplicated_event_patterns.go
• pkg/monitortestlibrary/pathologicaleventlibrary/duplicated_events_special_test.go

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.

---

Walkthrough

The overlap matcher can use an event’s latest occurrence timestamp. The vSphere matcher enables this behavior, recognizes additional rollout events, updates its message pattern and Jira reference, and adds positive and negative test coverage.

Changes

vSphere event matching

Layer / File(s)	Summary
Timestamp-aware overlap matching pkg/monitortestlibrary/pathologicaleventlibrary/duplicated_event_patterns.go	The overlap matcher adds useLastTimestamp. When enabled, Allows retains the interval’s latest timestamp instead of parsing firstTimestamp.
vSphere pattern validation pkg/monitortestlibrary/pathologicaleventlibrary/duplicated_event_patterns.go, pkg/monitortestlibrary/pathologicaleventlibrary/duplicated_events_special_test.go	The vSphere matcher recognizes ScalingReplicaSet reasons and VMware CSI driver messages. Tests verify accepted last-occurrence timestamps and rejection of out-of-window or unrelated scaling events.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to ae403

This PR makes a localized change to pathological-event test behavior, and no actionable merge-blocking risk remains beyond normal checks and review.

Suggested reviewers: eggfoobar, mdbooth

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title identifies the main change as a fix for pathological event matching, which aligns with the pull request changes.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The added test uses the static title TestVsphereConfigurationMatcherUsesLastOccurrence and static t.Run names; timestamps and generated-looking names occur only in fixture data, not titles.
Test Structure And Quality	✅ Passed	The added test is a table-driven Go unit test, not Ginkgo cluster code; it creates no resources, uses no waits, and all new assertions have diagnostic messages.
Microshift Test Compatibility	✅ Passed	The added test is a standard Go testing.T unit test with no Ginkgo It/Describe/Context blocks, so this MicroShift e2e compatibility check does not apply.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The added test is a standard Go test with t.Run in a unit-test package; it adds no Ginkgo e2e It, Describe, Context, or When test and makes no SNO topology assumption.
Topology-Aware Scheduling Compatibility	✅ Passed	The diff changes only pathological-event matching logic and tests; it adds no manifests, operators, controllers, replicas, affinity, topology spread, selectors, taints, or PDBs.
Ote Binary Stdout Contract	✅ Passed	The PR adds matcher logic and tests only; the diff introduces no fmt, klog, stdout, or process-level setup writes, and existing logrus calls are unchanged.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The added test is a standard Go testify unit test, not a Ginkgo e2e test. It uses synthetic timestamps and cluster object names, with no IPv4 literals or external connectivity.
No-Weak-Crypto	✅ Passed	The PR changes timestamp handling, event regexes, Jira metadata, and tests. The diff adds no MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB, custom crypto, or secret comparisons.
Container-Privileges	✅ Passed	The PR changes only Go matcher logic and tests. The exact diff adds no container/Kubernetes privilege settings such as privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, or allowPrivilegeEscalat...
No-Sensitive-Data-In-Logs	✅ Passed	The diff adds no logging calls or sensitive values. The existing overlap log emits interval resource names/messages, and new data is limited to vSphere resource names and timestamps.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-merge-bot]

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

[gnufied]

/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

[gnufied]

/jira refresh

[openshift-ci-robot]

@gnufied: This pull request references Jira Issue OCPBUGS-86257, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.1.0) matches configured target version for branch (5.1.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[dgoodwin]

/payload-job periodic-ci-openshift-release-main-nightly-5.0-e2e-vsphere-ovn-upi-serial

Looks like it was serial jobs this was hitting.

[openshift-ci]

@dgoodwin: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-nightly-5.0-e2e-vsphere-ovn-upi-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/5c506340-9d51-11f1-9206-d78fdb14e536-0

[dgoodwin]

/approve
/lgtm

[dgoodwin]

/override ci/prow/e2e-gcp-ovn-upgrade
/hold

[dgoodwin]

Suggest waiting for the vsphere serial job launched above before verifying

[openshift-ci]

@dgoodwin: Overrode contexts on behalf of dgoodwin: ci/prow/e2e-gcp-ovn-upgrade

Details

In response to this:

/override ci/prow/e2e-gcp-ovn-upgrade
/hold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgoodwin, gnufied

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [dgoodwin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[gnufied]

Looks like it passed -https://prow.ci.openshift.org/view/gs/test-platform-results/logs/openshift-origin-31543-nightly-5.0-e2e-vsphere-ovn-upi-serial/2090759240779042816

/hold cancel

[dgoodwin]

/verified by CI

[openshift-ci-robot]

@dgoodwin: This PR has been marked as verified by CI.

Details

In response to this:

/verified by CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@gnufied: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

@gnufied: Jira Issue Verification Checks: Jira Issue OCPBUGS-86257
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-86257 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

Fixes https://redhat.atlassian.net/browse/OCPBUGS-86257

Summary by CodeRabbit

• Bug Fixes
• Improved VMware vSphere event matching by using the latest occurrence when evaluating overlapping events.
• Added support for matching scaling-related rollout events.
• Refined event message matching for greater accuracy.
• Tests
• Added coverage for valid rollout events, out-of-window events, unrelated scaling events, and events with differing first and last occurrences.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.