Migrate from Newtonsoft.Json to System.Text.Json - #2189
Merged
Merged
Conversation
Member
Author
|
May I ask if you can test if Vogen and Voicevox still works without issues? @rokujyushi |
Contributor
|
It seems that Newtonsoft.Json has a mechanism that automatically performs type conversion, but thanks to the strict conversion process of Json.Deserialize, a bug that had remained undetected until now has been discovered. Click here for the fix PR. |
fix: correct VOICEVOX JSON numeric type definitions
rokujyushi
approved these changes
Jun 11, 2026
Contributor
|
Sorry, I just remembered there was this fix too. My feature addition is probably causing a conflict, so could you please fix it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eliminate the need of using two Json parsers and only use System.Text.Json instead.
OpenUtau.Core.Json(similar toYaml) to store default JsonSerializerOptions and wrapper methods for Deserialize and Serialize.