Repository navigation
Conversation
leftwo
force-pushed
the
alan/been-active-v14-ds-you-have-been-active
branch
2 times, most recently
from
October 30, 2026 20:04
1790440 to
db579c7
Compare
leftwo
force-pushed
the
alan/been-active-v14-ds-you-have-been-active
branch
from
November 2, 2026 17:19
db579c7 to
604ee70
Compare
jmpesp
approved these changes
Nov 2, 2026
leftwo
force-pushed
the
alan/been-active-v14-ds-you-have-been-active
branch
3 times, most recently
from
November 3, 2026 01:35
9aafe4f to
b505e0e
Compare
On a connection that negotiated V14 or later with a read-write region, negotiation now includes BeenActivePlease - BeenActive. V13 and read-only connections still finish straight after RegionInfo. Handle YouHaveBeenActive on a running connection. The upstairs and session IDs are checked like other messages that carry them. On V13 or a read-only region sending YouHaveBeenActive drops the connection (as any unexpected message does today). When expected we record been_active in the region. V14 is not in supported() yet, so no live connection is affected.
Made the comments reflect the decision to abort connections when we can't write the (now named) private file.
leftwo
force-pushed
the
alan/been-active-v14-ds-you-have-been-active
branch
from
November 3, 2026 02:13
b505e0e to
376ac9b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a connection that negotiated V14 or later with a read-write region,
negotiation now includes sending the BeenActivePlease - BeenActive sequence.
V13 and read-only connections still finish straight after RegionInfo.
Also, handle receipt of YouHaveBeenActive on a running connection, and
update the file in the region directory so this state is persisted.
On V13 or a read-only region sending YouHaveBeenActive drops the connection
(as any unexpected message does today).
V14 is not in supported() yet, so no live connection is affected.
More to come in the upstairs where we would send these messages.