Repository navigation
reject requests for API versions older than the oldest supported one - #2061
Merged
Merged
Conversation
leftwo
approved these changes
Oct 31, 2026
leftwo
left a comment
leftwo
left a comment
Contributor
There was a problem hiding this comment.
This should be fine, because we only have one version so far for these APIs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I recently discovered that the way we do versioning with Dropshot servers, servers do not properly reject requests with version numbers older than the oldest supported version. This change uses a new Dropshot helper to reject these requests. (See oxidecomputer/dropshot#1754.) This should not come up in practice since both MUPdate and self-service update ensure that we always have matched client and server versions. But if they ever do mismatch, we want it to fail crisply and explicitly.