Repository navigation
Validate mutually exclusive groups in parse_known_args - #436
Merged
p-ranav merged 4 commits intoOct 2, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parse_known_args currently accepts conflicting members of mutually exclusive groups and allows required groups to remain unused. This shares the existing post-parse validation with parse_args so both public entry points enforce the same constraints, preserving exception text and validation order.
Adds regression coverage for optional and required groups, explicit use versus defaults, multiple groups, unknown-argument preservation, argc/argv and individual-argument error precedence. Addresses the top-level behavior in #400; subparser recursion is outside this change.
Validation: four new regression cases fail on the original header. With the patch, all 270 C++17 tests and 957 assertions pass on GCC13.2 for Windows UCRT; one existing test is skipped. The eight-case reproduction has no remaining behavior mismatch. Modules and std::format build variants were not exercised.
AI tools assisted implementation, test development and review. All reported tests were executed locally; the uploaded files match the tested sources.