Skip to content

Fix argument count error - Depends on https://github.com/php-db/phpdb-mysql/pull/57 - #78

Draft
tyrsson wants to merge 1 commit into
mago-format-reformatfrom
patch-mysqli-statement-missing-clone
Draft

Fix argument count error - Depends on https://github.com/php-db/phpdb-mysql/pull/57#78
tyrsson wants to merge 1 commit into
mago-format-reformatfrom
patch-mysqli-statement-missing-clone

Conversation

@tyrsson

@tyrsson tyrsson commented Aug 16, 2026

Copy link
Copy Markdown
Member

Proposed fix for the argument count error around parameter binding. See https://github.com/tyrsson/messagebus-test/blob/master/docs/failure-notes.md#6 for more details.

Signed-off-by: Joey Smith jsmith@webinertia.net

Types of changes

  • Documentation improvement
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • RFC (Request for Comments, a discussion topic)
  • QA improvement (unit/integration tests, CS fixes, etc.) that does not change code behavior

Checklist:

  • An issue has been created for this pull request.
  • I have added tests for my changes.
  • All new and existing tests passed.
  • Documentation has been updated accordingly.
  • This pull request targets the correct branch.

Description

Motivation and Context

How has this been tested?

Screenshots (if appropriate):

Proposed fix for the argument count error around parameter binding.
See https://github.com/tyrsson/messagebus-test/blob/master/docs/failure-notes.md#6 for more details.

Signed-off-by: Joey Smith <jsmith@webinertia.net>
@tyrsson tyrsson self-assigned this Aug 16, 2026
@tyrsson
tyrsson marked this pull request as draft August 16, 2026 16:26
@tyrsson
tyrsson requested a review from simon-mundy August 16, 2026 16:26
@tyrsson tyrsson changed the title Depends on https://github.com/php-db/phpdb-mysql/pull/57 Fix argument count error - Depends on https://github.com/php-db/phpdb-mysql/pull/57 Aug 16, 2026
@tyrsson tyrsson added this to the 0.5.0 milestone Aug 16, 2026
@tyrsson

tyrsson commented Aug 16, 2026

Copy link
Copy Markdown
Member Author

Related to #67

@tyrsson

tyrsson commented Aug 16, 2026

Copy link
Copy Markdown
Member Author

Once I get time to do a deep dive into how this came about, which I am pretty sure I already know but I want to verify it. I will create a tracking issue specifically for this.

Might be a good case for adding __clone to the StatementInterface.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant