Remove 11 unused entities still referenced by translations#5628
Open
lacatoire wants to merge 7 commits into
Open
Remove 11 unused entities still referenced by translations#5628lacatoire wants to merge 7 commits into
lacatoire wants to merge 7 commits into
Conversation
sy-records
approved these changes
Jun 19, 2026
lacatoire
force-pushed
the
cleanup/translation-referenced-entities
branch
from
58129ba to
1571305
Compare
Record them as tombstones in entities/entities-remove.ent (translate="remove") so revcheck gives translations a heads up, instead of a plain deletion.
lacatoire
force-pushed
the
cleanup/translation-referenced-entities
branch
from
1571305 to
8ee3aa0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the unused-entities cleanup, kept separate because these 11 entities are still referenced by some translations (it/ro/uk/tr/ru/es, depending on the entity).
They are unused in doc-en (directly or transitively), so removing them changes no rendered EN output. Instead of a plain deletion, they are now recorded as tombstones in
entities/entities-remove.ent(translate="remove"), so revcheck gives the translations a heads up to drop them on their side.Stacked on #5634, which introduces the
entities/mechanism. Also waiting for php/doc-base#301 to be merged.