Update transferList type in emit method signature - #233
Open
verheyenkoen wants to merge 2 commits into
Open
verheyenkoen wants to merge 2 commits into
verheyenkoen wants to merge 2 commits into
Conversation
mcollina
requested changes
Jul 13, 2026
mcollina
left a comment
mcollina
left a comment
Member
There was a problem hiding this comment.
can you add a test for this type?
Author
@mcollina I've tried this locally but the type test would only work if we bump @types/node to "^26". Since TransferListItem and Transferable are "equal types", no test feature that I know of could verify this deprecation in @types/node@25. Is that ok to add as well? |
Member
|
that's ok |
|
This looks like a good patch! @verheyenkoen planning on rebasing? want a hand? |
verheyenkoen
force-pushed
the
patch-1
branch
from
September 8, 2026 07:41
b2b75ff to
2b67a6a
Compare
wheelsandcogs
added a commit
to Marvell-Consulting/find-public-health-data
that referenced
this pull request
Sep 10, 2026
@types/node 26 renamed worker_threads.TransferListItem to Transferable, and thread-stream (via pino) still uses the old name in its typings, so every package that imports pino failed to typecheck. Carry the one-line upstream fix (pinojs/thread-stream#233) as a pnpm patch until it ships; pnpm will refuse to apply it once thread-stream moves past 4.2.0. 26.4.1 rather than 26.5.x because of the three-day minimumReleaseAge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FIXES #228