Repository navigation
Default new site flow to provisioning instead of register - #6856
Open
RobertJoonas wants to merge 1 commit into
Open
RobertJoonas wants to merge 1 commit into
RobertJoonas wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
When the user navigates to
/sites/newwithout theflowparam present (e.g. by entering the URL manually), we currently send them through onboarding by default. This PR changes the default to?flow=provisioning.This was highlighted in a review comment: #6822 (comment), but couldn't be changed at the time because the
create_site_email(a reminder to people who've signed up but haven't added a site or created a team yet) was linking to plain/sites/new. That PR changed the link in the email to include?flow=register(and the redirect after register form login).Now that we've been sending out those emails with an explicit link to the register flow for 8 days, it should be safe to change the default. Worst case (if a user clicks the link from an email that was sent from before that change) is that the user gets provisioning flow instead of register.
Tests
Changelog
Documentation
Dark mode