fix: refresh package type inference per compilation - #1056
Open
OskarEichler wants to merge 1 commit into
Open
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
Prevent automatic module-system inference from reusing stale
package.jsontypes across rebuilds.The current cache is process-wide. Webpack correctly watches the discovered
package.json, but after that file changes and starts a new compilation, the loader reads the old cached type instead of the updated file. Different compilation root boundaries can likewise share an inference that was valid only for the compilation that populated it.Implementation
Keep the existing path cache per compilation in a
WeakMap. Sibling modules in one compilation still avoid repeated filesystem traversal, while a new compilation re-evaluates its watched package metadata. Completed compilations and their maps can be garbage-collected.Verification
type: moduletotype: commonjsbetween compilation contexts. It fails on currentmainand passes with this change.Compatibility / breaking changes
No public API, dependency, runtime, or supported-platform changes. Explicit
esModuleoptions and extension-based inference remain unchanged.