fix: render runtime stack frames as text - #1058
Open
OskarEichler wants to merge 1 commit into
Open
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
Render parsed runtime stack function names and filenames as text rather than assigning them to
innerHTML.Stack frame values can contain markup-like characters. The runtime overlay currently turns those values into live DOM elements, which both corrupts the displayed trace and allows markup attributes to become active inside the development overlay.
Implementation
Use
textContentfor fallback text, function names, and filenames. Unicode em spaces preserve the indentation previously produced by entities.Verification
mainby creatingimgandstrongelements, and passes with the values preserved as literal text.Compatibility / breaking changes
No public API, dependency, socket integration, or supported-platform changes. Runtime stack values display literally instead of being interpreted as HTML.