Repository navigation
Add missing runtime dependencies to the pylint pre-commit hook - #481
Merged
Merged
Conversation
4 tasks done
kwk
approved these changes
Sep 7, 2026
ammachado
marked this pull request as ready for review
September 7, 2026 18:37
psss
approved these changes
Oct 9, 2026
The pylint hook was reporting import-error across the plugin modules. import-error is not in the disable= list in .pylintrc, and pre-commit runs each hook in its own isolated virtualenv, so the init-hook sys.path extension only ever sees the hook's own venv. Without these, pylint cannot resolve feedparser, koji, nitrate, bodhi-client and friends, and reports an error per plugin. This mirrors the list the mypy hook directly below already carries. The difference between the two is that pylint needs the real packages where mypy wants the stubs, hence requests and python-dateutil here instead of types-requests and types-python-dateutil. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pylint
pre-commithook reportsimport-erroracross the pluginmodules.
import-erroris not in thedisable=list in.pylintrc, andpre-commit runs each hook in its own isolated virtualenv, so the
init-hooksys.pathextension only ever sees the hook's own venv.Without these dependencies pylint cannot resolve
feedparser,koji,nitrate,bodhi-clientand friends, and reports one error per plugin.This mirrors the list the mypy hook directly below already carries. The
difference between the two is that pylint needs the real packages where
mypy wants the stubs, hence
requestsandpython-dateutilhere insteadof
types-requestsandtypes-python-dateutil.Split out of #469.
🤖 Generated with Claude Code