Conversation
|
|
kenyon
approved these changes
Apr 16, 2024
halfninja
added a commit
to UniversityofWarwick/puppetlabs-docker
that referenced
this pull request
Sep 3, 2025
Member
|
@akremer : My apologies that this PR hasn't been looked at in so long! I'm going through the old open ones and trying to determine if this should stay open and move forward, or be closed off. The fix looks small and targeted, but the branch has some conflicts now. From a quick look at main, it seems like the bug is still there. If you still have a need for this PR, would you be able to resolve the conflicts? |
jst-cyr
added
the
cancelled
Member
|
Closing this PR for now until a need rises for this in the future at which point we can re-open! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses #973. Using Puppet::Util::Yaml.safe_load rather than just YAML.safe_load already contains a check for this specific issue.
Note, there are numerous other issues with this method and file, (#968, #878, #848, etc). I will be proposing a separate update to fix those, but this is just a small atomic update to fix this specific issue.
Additional Context
#973 contains the additional context
Related Issues (if any)
Mention any related issues or pull requests.
Checklist
puppet apply)