Gcvcallp 3344 4.0 backport combined - #162
Merged
Merged
Conversation
… eventfd curl_multi_fdset()'s read set can include libcurl's own wakeup eventfd alongside the real transfer socket (observed on 8.21.0, not 8.17.0). is_new_transfer() only checks fd numbers, not fd type, so it could register the eventfd instead of the socket. Add a SO_TYPE check before trusting a candidate fd. Co-Authored-By: Claude Sonnet 5 (cherry picked from commit ff3226c) (cherry picked from commit 3e48a0d)
…cord-Route lumps Backport of upstream fix: after rewriting the auto Record-Route header on the initial request, the RECORDROUTE add-lumps created earlier by th_no_dlg_add_auto_record_route() were never freed, leaking pkg memory per request. (cherry picked from commit c9a3551) Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> (cherry picked from commit 22d776d)
(cherry picked from commit 1923da5)
SubhashC37
requested review from
DHennessyGenesys,
benceszigeti,
john-macaslan-gc,
kordian-pawelec and
sekharp-genesys
September 30, 2026 10:40
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
benceszigeti
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Details
Solution
Compatibility
Closing issues