Skip to content

Annotate dtolnay/rust-toolchain SHA pin with its ref#15326

Closed
duksh wants to merge 1 commit into
pyca:mainfrom
duksh:claude/upstream-toolchain-pin-comment
Closed

Annotate dtolnay/rust-toolchain SHA pin with its ref#15326
duksh wants to merge 1 commit into
pyca:mainfrom
duksh:claude/upstream-toolchain-pin-comment

Conversation

@duksh

@duksh duksh commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

Every other SHA-pinned action carries a version comment; this one lacked it because dtolnay/rust-toolchain publishes no tags.

This annotates the three uses with the branch and commit date (master, as of Aug 23, 2025), matching the style used for the BoringSSL commit pins.

Every other SHA-pinned action carries a version comment; this one
lacked it because rust-toolchain publishes no tags. Note the branch and
commit date instead, matching the style used for BoringSSL pins.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DWoMomNAcBM3e8duJrb2do
@alex

alex commented Jul 25, 2026

Copy link
Copy Markdown
Member

AFAIK this syntax will not be automatically updated by dependabot, which means it'll immediately fall out of date. Unless there's a way to have dependabot keep the comments up to date, this is better left unannotated.

@duksh

duksh commented Jul 25, 2026

Copy link
Copy Markdown
Contributor Author

That's fair — Dependabot wouldn't keep this format current, so it would go stale on the first bump. Closing.

@duksh duksh closed this Jul 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants