Repository navigation
Apply the tagged union strategy to subsets of the configured union - #829
Closed
Aschenbath wants to merge 1 commit into
Closed
Aschenbath wants to merge 1 commit into
Aschenbath wants to merge 1 commit into
Conversation
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #348.
configure_tagged_uniononly registered hooks for the exact union it was given. A field typed with a subset of that union (for exampleA | BwhenA | B | Cwas configured) fell back to the default disambiguation, which fails for members it cannot tell apart:The strategy now also registers structure and unstructure hook factories that claim any other union whose members are a subset of the configured union's members. The tag alone decides the member, and every member of a subset is already in the tag map, so the same hooks are reused. An additional
Nonemember is allowed, so optional subsets (A | B | None) work too; at least two real members are required, so a plainOptional[member]field is not claimed. A subset that is configured or registered separately keeps its own direct hooks, which take precedence over these factories.Verification
A | B | Nonefield.test_subset_unionintests/strategies/test_tagged_unions.py.tests/strategies/,tests/test_unions.pyandtests/test_disambiguators.py: 327 passed, 15 xfailed.ruff checkandruff formatclean on the touched files.