Repository navigation
Skip dynamic Python arguments during message extraction - #1448
Open
Denny-j-mangalathu wants to merge 1 commit into
Open
Denny-j-mangalathu wants to merge 1 commit into
Denny-j-mangalathu wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python message extraction can emit fragments of dynamic arguments. For example,
_('prefix' + suffix)currently addsprefixto the catalog even though gettext receives the computed value.Track whether each argument consists of string literals. Skip dynamic arguments while preserving argument positions, adjacent literal concatenation, and the existing translator comment handling.
Closes #415.
The regression test fails on upstream master. With the fix, 86 extraction, lexer, and extraction frontend tests pass. The frontend tests used locale data from the published Babel package because the CLDR source download did not complete.
Prepared with Codex assistance.