Repository navigation
Retry lazy attribute lookups after a transient factory error - #1451
Closed
shrohan2003 wants to merge 1 commit into
Closed
shrohan2003 wants to merge 1 commit into
shrohan2003 wants to merge 1 commit into
Conversation
Member
|
I don't think this is necessary. |
Author
|
Thanks for taking a look, @akx. Understood. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a LazyProxy factory raises AttributeError once, calling a method on the proxy again re-raises the saved exception without retrying the factory. This can leave a proxy unusable even after its backing value becomes available.
Limit replay of the property's exception to lookup of the value property itself, and clear it after successful evaluation. The regression test exercises a fail-once factory through a forwarded method with caching enabled and disabled.