gh-152902: Add Intel icx compiler to configure.ac#152825
Open
hpkfft wants to merge 3 commits into
Open
Conversation
hpkfft
requested review from
AA-Turner,
corona10,
emmatyping,
erlend-aasland and
itamaro
as code owners
July 1, 2026 21:06
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Member
|
Please open an issue. |
icc to icxicc to icx
zware
reviewed
Jul 19, 2026
zware
left a comment
Member
There was a problem hiding this comment.
Overall, this looks good. However, even given your good reasons for removing it, I'd rather keep the legacy icc cases for now.
This will also need a NEWS entry in the Build section.
icc to icxicx compiler to configure.ac
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Intel(R) oneAPI DPC++/C++ Compiler 2026.0.0 is not officially supported by CPython, and I am not suggesting to change that.
However, I see that there is code in
configure.acthat applies to the Intel classic compiler (iccfor C andicpcfor C++). The last version of the classic compiler was 2021.10 and it stopped shipping in 2023.I would like to suggest updating
icctoicxinconfigure.ac.Note that not all tests pass. In particular:
and
I do not think the Intel math library is wrong here; it's OK to set
errnotoEDOMforatan2(0.0, 0.0). GCC using glibc does not, and that's OK too. Both libraries return0.0foratan2(0.0, 0.0)andmath.piforatan2(0.0, -0.0).If I comment out those tests, I can compile locally with PGO. Also,
icxdoes support-Wno-unused-result, and-ffp-model=preciseis needed or else other floating-point tests will fail. (As noted in the comment, clang usespreciseby default. The Intel compiler is based on clang, but it has changed the default tofast.)icctoicx#152902