gh-141276: Avoid compiling zipimport source in get_filename#153799
Open
harjothkhara wants to merge 2 commits into
Open
gh-141276: Avoid compiling zipimport source in get_filename#153799harjothkhara wants to merge 2 commits into
harjothkhara wants to merge 2 commits into
Conversation
harjothkhara
requested review from
FFY00,
brettcannon,
ericsnowcurrently,
ncoghlan and
warsaw
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
zipimporter.get_filename()called_get_module_code(), which compiled source while import machinery was creating the module spec. Module execution then compiled the same source again.Tests
./python.exe -m test test_zipimport -m test_syntax_warning -m testBadMagic -m testBadMTime./python.exe -m test test_zipimportFixes #141276
Duplicate-work check
No open or merged pull request referencing #141276 was found before submission.
AI assistance
OpenAI Codex assisted with investigation, implementation, testing, and review.