gh-153691: Fix empty-list handling in PyInitConfig_*StrList#153816
Open
AayushMainali-Github wants to merge 1 commit into
Open
gh-153691: Fix empty-list handling in PyInitConfig_*StrList#153816AayushMainali-Github wants to merge 1 commit into
AayushMainali-Github wants to merge 1 commit into
Conversation
malloc(0) may return NULL on some platforms. Treat empty string lists as a successful no-allocation result instead of out-of-memory.
AayushMainali-Github
requested review from
FFY00 and
ericsnowcurrently
as code owners
July 16, 2026 18:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PyInitConfig_GetStrList()andPyInitConfig_SetStrList()usedmalloc(n * sizeof(...))even whenn == 0. On platforms wheremalloc(0)returnsNULL, that was treated as an out-of-memory failure, so a valid empty list (for example the defaultxoptions) incorrectly failed.This change skips
malloc(0)for empty lists:GetStrListreturnslength == 0anditems == NULLSetStrListstores{.length = 0, .items = NULL}(same as_PyWideStringList_INIT)This matches the existing empty-list handling in
_PyWideStringList_CopyEx().Fixes #153691.
Test plan
LD_PRELOADforcingmalloc(0)→NULLGetStrList-style empty alloc returns-10withitems == NULL./python -m test test_embed -v -m test_initconfig_get_api./Programs/_testembed test_initconfig_get_api(with and without the preload)./python -m test test_embed -v -m 'test_initconfig*'