gh-118150: warn in doc about results asymmetry for difflib junk#153892
gh-118150: warn in doc about results asymmetry for difflib junk#153892Lenormju wants to merge 4 commits into
Conversation
|
All commit authors signed the Contributor License Agreement. |
Documentation build overview
16 files changed ·
|
|
|
||
| This heuristic only ever inspects the second sequence for junk. That has | ||
| an unexpected consequence: swapping the inputs can produce a different | ||
| diff than simply reversing the output, sometimes very large. |
There was a problem hiding this comment.
This sounds ungrammatical.
Do we need to note that output can be very large?
| diff than simply reversing the output, sometimes very large. | |
| diff than reversing the output. |
There was a problem hiding this comment.
I think yes, because it is the original issue, and the most unexpected behavior. #118150 describes a pathological case where, depending on the inputs' order, the diff can be 1186x bigger. I call that surprising, and very large. In this case, it was because most lines got autojunked.
I will fix the grammar right now, sorry for that.
There was a problem hiding this comment.
I reworded the two junk-related paragraphs.
About the size:
But it can also cause pathological cases where too many items considered junk cause an unexpectedly large (but correct) diff result.
2 participants
Uh oh!
There was an error while loading. Please reload this page.