gh-154070: Build the curses module wide by capability, not by name#154071
Open
serhiy-storchaka wants to merge 4 commits into
Open
gh-154070: Build the curses module wide by capability, not by name#154071serhiy-storchaka wants to merge 4 commits into
serhiy-storchaka wants to merge 4 commits into
Conversation
configure built the module wide (HAVE_NCURSESW) only for a backend named ncursesw. Probe for the wide API in the ncurses and auto backends too, so a widec-built ncurses keeping the plain name (pkgsrc, macOS) is built wide. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
serhiy-storchaka
requested review from
AA-Turner,
corona10,
emmatyping,
erlend-aasland and
itamaro
as code owners
July 19, 2026 09:17
…r build The wide-character probe ran inside a nested WITH_SAVE_ENV, whose single CPPFLAGS save slot is not reentrant, so the outer restore leaked $CURSES_CFLAGS and $PANEL_CFLAGS (-D_XOPEN_SOURCE=600) into CONFIGURE_CPPFLAGS and thus into every translation unit, producing a '_XOPEN_SOURCE' redefined warning against pyconfig.h on every file. Save and restore CPPFLAGS with a dedicated variable around the probe. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
configurechose wide vs narrow (HAVE_NCURSESW) by the pkg-config name —ncurseswwide,ncursesnarrow — but wide support is a property of the library, not its name. A widec-built ncurses that keeps the plainlibncurses/ncurses.pcname (pkgsrc on NetBSD/illumos, macOS system ncurses) was built narrow, losing the wide API and limitingaddch()/getch()/inch()to ASCII in UTF-8 locales.This runs the existing wide-API probe (
setcchar()/add_wch(), added for the nativecursesbackend in gh-136687) for thencurses/autobackends too, definingHAVE_NCURSESWby capability. On macOS, where the locale is UTF-8, this turns a nearly unusable narrow build into a wide one.Validated: Linux
ncurseswstays wide and narrowncurses/cursesstay narrow; OpenIndiana and NetBSD pkgsrc ncurses go narrow → wide (NetBSDtest_curses162 run / 1 skip SUCCESS). macOS cannot be tested locally — the buildbots will.