gh-154435: Fix os.posix_fadvise() and os.posix_fallocate() on DragonFly BSD#154436
Merged
serhiy-storchaka merged 1 commit intoJul 22, 2026
Merged
Conversation
…ragonFly BSD They return -1 and set errno instead of returning the error number, so OSError was raised with a meaningless error code. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
serhiy-storchaka
added
needs backport to 3.13
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15. |
|
GH-154451 is a backport of this pull request to the 3.15 branch. |
bedevere-app
Bot
removed
the
needs backport to 3.15
|
GH-154452 is a backport of this pull request to the 3.14 branch. |
|
GH-154453 is a backport of this pull request to the 3.13 branch. |
serhiy-storchaka
added a commit
that referenced
this pull request
Jul 22, 2026
…DragonFly BSD (GH-154436) (GH-154453) They return -1 and set errno instead of returning the error number, so OSError was raised with a meaningless error code. (cherry picked from commit 08a0d10) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com> Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
POSIX specifies that these functions return the error number and do not set
errno, but on DragonFly BSD they return -1 and seterrno, soOSErrorwas raised with[Errno -1].Use
errnoif the function returns -1. This also fixes retrying onEINTR, which compared the returned value withEINTR.