Skip to content

Update bytecode magic number for the 3.15 release candidate - #154881

Merged
hugovk merged 2 commits into
python:mainfrom
hugovk:3.15-magic-number
Jul 30, 2026
Merged

Update bytecode magic number for the 3.15 release candidate#154881
hugovk merged 2 commits into
python:mainfrom
hugovk:3.15-magic-number

Conversation

@hugovk

@hugovk hugovk commented Jul 29, 2026

Copy link
Copy Markdown
Member

The release script reminds:

warning: Magic numbers in ../cpython/Include/internal/pycore_magic_number.h (3666) and ../cpython/Lib/test/test_importlib/test_util.py (3625) don't match.
Do you want to continue? This will fail tests in RC stage.

@hugovk hugovk added the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Jul 29, 2026
@hugovk
hugovk requested review from FFY00, ncoghlan and warsaw as code owners July 29, 2026 13:36
@bedevere-app bedevere-app Bot added tests Tests in the Lib/test dir awaiting core review labels Jul 29, 2026
StanFromIreland
StanFromIreland approved these changes Jul 29, 2026
View reviewed changes
Comment thread Lib/test/test_importlib/test_util.py Outdated
@@ -647,7 +647,7 @@ def test_magic_number(self):

@StanFromIreland StanFromIreland Jul 29, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we switch this to "on Discourse"?

@hugovk hugovk Jul 30, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, updated!

StanFromIreland
StanFromIreland approved these changes Jul 30, 2026
View reviewed changes

@StanFromIreland StanFromIreland left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@hugovk
hugovk merged commit 6489af6 into python:main Jul 30, 2026
47 checks passed
@hugovk
hugovk deleted the 3.15-magic-number branch July 30, 2026 19:48
@miss-islington-app

miss-islington-app Bot commented Jul 30, 2026

Copy link
Copy Markdown

Thanks @hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖

@bedevere-app

bedevere-app Bot commented Jul 30, 2026

Copy link
Copy Markdown

GH-154955 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Jul 30, 2026
hugovk added a commit that referenced this pull request Jul 30, 2026
@miss-islington @hugovk
[3.15] Update bytecode magic number for the 3.15 release candidate (G…
aca93c8 
…H-154881) (#154955)

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@keelanfh keelanfh mentioned this pull request Jul 30, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StanFromIreland StanFromIreland StanFromIreland approved these changes
@brettcannon brettcannon Awaiting requested review from brettcannon brettcannon is a code owner
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner
@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner
@FFY00 FFY00 Awaiting requested review from FFY00 FFY00 is a code owner

Assignees

No one assigned

Labels

skip issue skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hugovk @StanFromIreland