fix(ci): restore documented CI job graph in test.yml - #51
Merged
Conversation
build and playwright-tests both drifted to gating on rust/vitest-tests in addition to deno-lint, producing a serial rust -> playwright -> build chain that docs/builds.md never described. Neither job consumes artifacts from rust or vitest-tests, so narrow both back to what the docs already document: deno-lint alone gates build, and deno-lint plus the frontend path filter gates playwright-tests. Also updates the dependency-graph doc itself, which still said "five jobs" and listed playwright-tests as fully independent -- stale since zig, shadow-diff, and changes were added and playwright-tests already depended on deno-lint.
pythoninthegrass
added a commit
that referenced
this pull request
Sep 14, 2026
…ements Records per-job wall-clock from PR #51's run, cold/warm task build:timings results, cargo tree dependency count, critical-path analysis, and a no-go recommendation for TASK-357 on CI-wall-clock grounds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
buildandplaywright-testshad drifted to gating onrust/vitest-tests(andplaywright-testsforbuild) in addition todeno-lint, producing a serialrust -> playwright -> buildchain thatdocs/builds.mdnever documented and that costs up to ~40 min of wall-clock per run.build'sneeds:to[deno-lint]andplaywright-tests'needs:to[changes, deno-lint]— matching whatdocs/builds.md's "Test Workflow Dependency Graph" section already claimed.zig/shadow-diff/changeswere added) and listedplaywright-testsas fully independent when it was already gated ondeno-lint.Why this is safe
Neither
buildnorplaywright-testsconsumes artifacts fromrustorvitest-tests:buildruns its own per-platformcargo check, andplaywright-testsruns against a Vite preview build with mocked IPC.Before/after (TASK-351 AC#3, AC#4)
Real PR-run data pulled via
gh run view --json jobs, not synthetic:Before (run 34811970745, TASK-355.6's PR, pre-fix graph):
mt-zig-corestaging bug, unrelated to this change)rust/vitest-testsfailurerust/vitest-tests/playwright-testsbuildandplaywright-testsnever ran at all — not delayed, dropped. That's the actual cost of the drifted graph: a single unrelatedrustjob failure silences build/E2E signal for the whole PR.After: see this PR's own run once CI completes —
buildandplaywright-testsshould now start immediately afterdeno-lintsucceeds regardless ofrust's outcome.Test plan
actionlint .github/workflows/test.yml— cleanbuildstarts within ~3 min ofdeno-lintcompleting (AC#3)docs/builds.mddependency graph re-verified againsttest.ymlpost-merge (AC#5)