Repository navigation
Listings: custom listings without fields: keep derivable description/image - #817
Merged
cscheid merged 2 commits intoOct 10, 2026
Conversation
…ields: keep derivable description/image #815's fields_items_carry gated custom listings without fields: on fields some item already carries, which missed a description or image only L7 can derive. Count those the way effective_fields does, so $items:item-default()$ still emits their envelopes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
…ription-precedence-x4bh6w3m-custom-derived-fields # Conflicts: # crates/quarto-core/src/project/listing/binding.rs
cscheid
deleted the
bugfix/bd-listing-description-precedence-x4bh6w3m-custom-derived-fields
branch
October 10, 2026 21:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #814 and #815 (bd-listing-description-precedence-x4bh6w3m).
#815 gave a
type: customlisting withoutfields:every field that some item carries (fields_items_carry). That check left out a description or image that only the L7 post-render pass can derive from the rendered page. In that caseshow.descriptionwas false, the built-initem-defaultpartial dropped the envelope, and the item showed no description. This happens when a page's first paragraph exists only after rendering: engine output, raw HTML, or a paragraph inside a div.fields_items_carrynow counts those fields the same wayeffective_fieldsalready does for the built-in layouts. This matches Q1, where every document item carries both placeholders.binding.rs: infields_items_carry,descriptionandimagealso count whenderivable(it, source).custom_listing_without_fields_keeps_derivable_fields.listing_derives_description_present_only_in_rendered_outputnow also covers a custom listing.repro/custom.qmdlistsderived-only/e.qmd, whose only paragraph is inside a div. Before the fix its description is missing; after the fix it shows.listings.qmd.cargo xtask verify --skip-hub-buildpasses locally.🤖 Generated with Claude Code