Don't log non-error "undefined method 'fields' for nil". - #440
Open
bglimepoint wants to merge 1 commit into
Open
Don't log non-error "undefined method 'fields' for nil".#440bglimepoint wants to merge 1 commit into
bglimepoint wants to merge 1 commit into
Conversation
`result` is nil when running `DELETE FROM public.que_jobs WHERE id = ::bigint`, which results in an error log.
oeoeaio
reviewed
Sep 8, 2026
| end | ||
|
|
||
| convert_result(result) | ||
| convert_result(result) unless result.nil? |
Contributor
There was a problem hiding this comment.
I note that there are other call sites for convert_result, I'm wondering if this is better placed as a guard clause inside convert_result rather than out here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resultis nil when runningDELETE FROM public.que_jobs WHERE id = $1::bigint, which results in an error log.Not sure whether this is something specific to us, but we're running 2.4.1 and are often seeing
"error":"NoMethodError: undefined method 'fields' for nil"in our Que logs. Looks like this is where it's coming from (insideconvert_resultwhen it callsresult.fields).