Add NoIR and wide camera modules to the sensor database - #332
Open
PineappleBeech wants to merge 2 commits into
Open
Add NoIR and wide camera modules to the sensor database#332PineappleBeech wants to merge 2 commits into
PineappleBeech wants to merge 2 commits into
Conversation
The correct values are 2, not 3. Signed-off-by: David Plowman <david.plowman@raspberrypi.com>
The NoIR and wide variants of the camera module 3 have different sensor model names. Signed-off-by: Peter Bailey <87275960+PineappleBeech@users.noreply.github.com>
|
Hi, |
Collaborator
|
@davidplowman should we update the vblank/hblank delays? |
Collaborator
Feels like we should, but are names like "imx708_noir", that aren't real sensor names, permissible, do you think? |
Collaborator
That change will have to stay downstream only. |
Collaborator
|
Perhaps the discussion over identifying modules within V4L2 can be nudged, as that is what this is. Same sensor (imx708) but with different optics (combinations of IR filter and lens). https://lore.kernel.org/linux-media/40b6589d-ef42-48d0-9853-341dc196fd18@kernel.org/
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The NoIR Wide Camera Module 3 uses imx708_wide_noir as its sensor's model so it is not found in camera_sensor_properties.cpp and uses the default properties instead. I've added imx708_wide and imx708_noir as well. I don't have either of them to so I can't check that those sensor model names are correct.
The NoIR Camera Module 1 uses the same sensor name as the version with an IR filter so it doesn't need a separate entry in the database.
I don't have a NoIR Camera Module 2 to test so it may need adding as well.