dmaengine: dw-axi-dmac: Wait for runtime resume...#7484
Open
pelwell wants to merge 1 commit into
Open
Conversation
...before using a channel dma_chan_alloc_chan_resources() called pm_runtime_get(), which only schedules the clock-enabling resume work asynchronously. If callers go on to configure and use the channel's registers immediately, the clocks may not yet be running, causing early register writes (e.g. CH_CFG) to be silently dropped. Later accesses succeed once the clock has come up, leaving the channel enabled but with an invalid configuration, and its completion interrupt never fires. Use pm_runtime_resume_and_get() so the clocks are guaranteed to be enabled before the channel is handed back to the caller. Fixes: 1fe20f1 ("dmaengine: Introduce DW AXI DMAC driver") Signed-off-by: Phil Elwell <phil@raspberrypi.com>
Contributor
Author
|
(updated with a Fixes: tag) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...before using a channel
dma_chan_alloc_chan_resources() called pm_runtime_get(), which only schedules the clock-enabling resume work asynchronously. If callers go on to configure and use the channel's registers immediately, the clocks may not yet be running, causing early register writes (e.g. CH_CFG) to be silently dropped. Later accesses succeed once the clock has come up, leaving the channel enabled but with an invalid configuration, and its completion interrupt never fires.
Use pm_runtime_resume_and_get() so the clocks are guaranteed to be enabled before the channel is handed back to the caller.