Repository navigation
Only require lspci on BCM2711 - #900
Closed
Firat17aze wants to merge 1 commit into
Closed
Firat17aze wants to merge 1 commit into
Firat17aze wants to merge 1 commit into
Conversation
Preserve the Pi4 dependency check while allowing Pi5 update operations without pciutils. Add four full-updater read-only dependency cases to the existing test entry point. OpenAI Codex automation prepared this change and validation. Host regression, complete EEPROM config suite and shell syntax checks pass on macOS. No physical Raspberry Pi, flashing or reboot test was performed.
Collaborator
|
Closing - untested AI code This also duplicates another issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rpi-eeprom-updaterejects a Pi 5 whenlspciis absent, even though its onlylspcicall is in the BCM2711 VL805 version path. This prevents otherwise supported bootloader-update operations on BCM2712 systems withoutpciutils.Require
lspcionly for BCM2711. Pi 4-class systems retain the existing missing-dependency error. Other dependency checks and update behavior are unchanged.Fixes #884.
The new host regression executes the actual updater's read-only
-lpath with board-revision fixtures, an isolated command PATH, and empty firmware directories. It covers Pi 5 and Pi 4 both with and withoutlspci. The original updater fails the Pi 5/no-lspci case with exit status 2; all four cases pass with this change. The test runs from the existing EEPROM config suite, so the existing CI entry point includes it.Validation on macOS ARM64:
sh test/test-rpi-eeprom-update: all four dependency cases pass.test/,sh test-rpi-eeprom-config: the complete existing image/config round-trip, signed-image, freeze, configuration-size and checksum tests pass, followed by the new updater regression. Used an isolated Python environment withpycryptodomex3.24.1 and the available checksum utilities; scratch files were kept in a dedicated TMPDIR.sh -nfor the updater and both test scripts, plus final diff and whitespace checks, pass.No physical Raspberry Pi execution, EEPROM flashing, or reboot testing was performed. The board and hardware-discovery commands are host fixtures; this verifies dependency selection and existing image tooling rather than device boot behavior. Linux CI has not yet run for this submission.
OpenAI Codex automation prepared the production conditional, host regression, test-suite integration, validation, and this description under the account owner's authorization. No unaided human work or physical-device testing is claimed.