Skip to content

fix: guard the fixed back-button restore against a removed sibling #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jongbonga wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: guard the fixed back-button restore against a removed sibling #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/transition/ios.transition.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,14 @@ const animateFixedBackButton = (
});
root.afterAddWrite(() => {
buttons.forEach(({ element, visibility }) => (element.style.visibility = visibility));
cloneParent.insertBefore(clone, cloneNextSibling);
// The sibling captured at build time may have left the DOM during the
// transition; insertBefore would then throw NotFoundError and the
// transition would never settle.
if (cloneNextSibling && cloneNextSibling.parentNode === cloneParent) {
cloneParent.insertBefore(clone, cloneNextSibling);
} else {
cloneParent.appendChild(clone);
}
if (cloneStyle === null) {
clone.removeAttribute('style');
} else {
Expand Down