Skip to content

Tweak LogBox notifications for iPhone Duo, fix rail touches #58958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
huntie wants to merge 1 commit into from
Closed

Tweak LogBox notifications for iPhone Duo, fix rail touches #58958

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion packages/react-native/Libraries/LogBox/LogBoxNotificationContainer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,15 +111,21 @@ export function LogBoxNotificationContainer(props: Props): React.Node {

const styles = StyleSheet.create({
list: {
alignItems: 'center',
bottom: 20,
left: 10,
right: 10,
// The container spans the width of the screen, so it passes touches outside the toasts through to the app, such
// as to a tab bar beside them.
pointerEvents: 'box-none',
position: 'absolute',
},
toast: {
borderRadius: 8,
borderRadius: 12,
marginBottom: 5,
maxWidth: 600,
overflow: 'hidden',
width: '100%',
},
});

Expand Down
6 changes: 3 additions & 3 deletions packages/react-native/Libraries/LogBox/UI/LogBoxNotificationDismissButton.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@ export default function LogBoxNotificationDismissButton(props: {
<LogBoxButton
id={props.id}
backgroundColor={{
default: LogBoxStyle.getTextColor(0.3),
pressed: LogBoxStyle.getTextColor(0.5),
default: LogBoxStyle.getTextColor(0.15),
pressed: LogBoxStyle.getTextColor(0.3),
}}
hitSlop={{
top: 12,
Expand Down Expand Up @@ -64,6 +64,6 @@ const styles = StyleSheet.create({
image: {
height: 8,
width: 8,
tintColor: LogBoxStyle.getBackgroundColor(1),
tintColor: LogBoxStyle.getTextColor(0.8),
},
});
22 changes: 18 additions & 4 deletions ...-native/Libraries/LogBox/__tests__/__snapshots__/LogBoxNotificationContainer-test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,10 @@ exports[`LogBoxNotificationContainer should render both an error and warning not
<SafeAreaView
style={
Object {
"alignItems": "center",
"bottom": 20,
"left": 10,
"pointerEvents": "box-none",
"position": "absolute",
"right": 10,
}
Expand All @@ -14,9 +16,11 @@ exports[`LogBoxNotificationContainer should render both an error and warning not
<View
style={
Object {
"borderRadius": 8,
"borderRadius": 12,
"marginBottom": 5,
"maxWidth": 600,
"overflow": "hidden",
"width": "100%",
}
}
>
Expand Down Expand Up @@ -59,9 +63,11 @@ exports[`LogBoxNotificationContainer should render both an error and warning not
<View
style={
Object {
"borderRadius": 8,
"borderRadius": 12,
"marginBottom": 5,
"maxWidth": 600,
"overflow": "hidden",
"width": "100%",
}
}
>
Expand Down Expand Up @@ -116,8 +122,10 @@ exports[`LogBoxNotificationContainer should render the latest error notification
<SafeAreaView
style={
Object {
"alignItems": "center",
"bottom": 20,
"left": 10,
"pointerEvents": "box-none",
"position": "absolute",
"right": 10,
}
Expand All @@ -126,9 +134,11 @@ exports[`LogBoxNotificationContainer should render the latest error notification
<View
style={
Object {
"borderRadius": 8,
"borderRadius": 12,
"marginBottom": 5,
"maxWidth": 600,
"overflow": "hidden",
"width": "100%",
}
}
>
Expand Down Expand Up @@ -175,8 +185,10 @@ exports[`LogBoxNotificationContainer should render the latest warning notificati
<SafeAreaView
style={
Object {
"alignItems": "center",
"bottom": 20,
"left": 10,
"pointerEvents": "box-none",
"position": "absolute",
"right": 10,
}
Expand All @@ -185,9 +197,11 @@ exports[`LogBoxNotificationContainer should render the latest warning notificati
<View
style={
Object {
"borderRadius": 8,
"borderRadius": 12,
"marginBottom": 5,
"maxWidth": 600,
"overflow": "hidden",
"width": "100%",
}
}
>
Expand Down
Loading