Live: Internalize argocd operator (DO NOT SQUASH-MERGE)- #1263 - #1286
Open
olivergondza wants to merge 1316 commits into
Open
Live: Internalize argocd operator (DO NOT SQUASH-MERGE)- #1263#1286olivergondza wants to merge 1316 commits into
olivergondza wants to merge 1316 commits into
Conversation
Signed-off-by: Jonathan West <jonwest@redhat.com>
…when HA enabled cluster has Only 3 worker nodes (#1933) * fix: redis ha proxy rolling update pod in pending state Signed-off-by: akhil nittala <nakhil@redhat.com> * fix: redis ha proxy rolling update pod in pending state Signed-off-by: akhil nittala <nakhil@redhat.com> * fix: redis ha proxy rolling update pod in pending state Signed-off-by: akhil nittala <nakhil@redhat.com> * fix: redis ha proxy rolling update pod in pending state Signed-off-by: akhil nittala <nakhil@redhat.com> --------- Signed-off-by: akhil nittala <nakhil@redhat.com>
…ild (#1911) Bumps ubi8/ubi-minimal from `58b1dc5` to `951ee3c`. --- updated-dependencies: - dependency-name: ubi8/ubi-minimal dependency-version: 951ee3cabb74246821ae31c2b808b7789310f5509882c153b7b178aaaeefa2d3 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dkarpele <karpelevich@gmail.com>
Signed-off-by: Jonathan West <jonwest@redhat.com>
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4 to 5. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@v4...v5) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…938) * Documentation for support of notifications in any namespace Signed-off-by: nmirasch <neus.miras@gmail.com> * Minor grammatical fix: use proper abbreviation formatting. Signed-off-by: nmirasch <neus.miras@gmail.com> * Removed extra content Signed-off-by: nmirasch <neus.miras@gmail.com> --------- Signed-off-by: nmirasch <neus.miras@gmail.com>
* Add testing for support notifications in any namespace Signed-off-by: nmirasch <neus.miras@gmail.com> * NotificationController ClusterRole reconciliation added Signed-off-by: nmirasch <neus.miras@gmail.com> * Avoid printing error when skipping reconciliation of resources regarding the target namespace is not enabled Signed-off-by: nmirasch <neus.miras@gmail.com> * Add checks Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com> * changed test description Signed-off-by: nmirasch <neus.miras@gmail.com> --------- Signed-off-by: nmirasch <neus.miras@gmail.com> Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com> Co-authored-by: Siddhesh Ghadi <sghadi1203@gmail.com>
Signed-off-by: Jonathan West <jgwest@gmail.com>
Assisted by: Cursor Signed-off-by: Jayendra Parsai <jparsai@redhat.com>
Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.43.0 to 0.45.0. - [Commits](golang/crypto@v0.43.0...v0.45.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-version: 0.45.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Jonathan West <jgwest@gmail.com>
* add namespace validation for notification resources Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com> * Fix e2e test Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com> --------- Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com>
* fix: namespace validation for sourcenamespace Assisted by: Cursor Signed-off-by: Jayendra Parsai <jparsai@redhat.com> * fix: namespace validation for sourcenamespace Assisted by: Cursor Signed-off-by: Jayendra Parsai <jparsai@redhat.com> * fix: namespace validation for sourcenamespace Signed-off-by: Jonathan West <jgwest@gmail.com> * fix: namespace validation for sourcenamespace Signed-off-by: Jonathan West <jgwest@gmail.com> --------- Signed-off-by: Jayendra Parsai <jparsai@redhat.com> Signed-off-by: Jonathan West <jgwest@gmail.com> Co-authored-by: Jonathan West <jgwest@gmail.com>
Signed-off-by: Jonathan West <jgwest@gmail.com>
Bumps [actions/checkout](https://github.com/actions/checkout) from 5 to 6. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v5...v6) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Jonathan West <jonwest@redhat.com>
Signed-off-by: Jonathan West <jgwest@gmail.com>
Signed-off-by: dkarpele <karpelevich@gmail.com>
Signed-off-by: Jonathan West <jgwest@gmail.com>
Signed-off-by: Jonathan West <jonwest@redhat.com>
…cleanup (#1978) Signed-off-by: nmirasch <neus.miras@gmail.com>
Signed-off-by: Jonathan West <jonwest@redhat.com>
…(#1987) Bumps [pymdown-extensions](https://github.com/facelessuser/pymdown-extensions) from 10.2.1 to 10.16.1. - [Release notes](https://github.com/facelessuser/pymdown-extensions/releases) - [Commits](facelessuser/pymdown-extensions@10.2.1...10.16.1) --- updated-dependencies: - dependency-name: pymdown-extensions dependency-version: 10.16.1 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ild (#1969) Bumps ubi8/ubi-minimal from `951ee3c` to `7b6b45d`. --- updated-dependencies: - dependency-name: ubi8/ubi-minimal dependency-version: 7b6b45dfd09bb032f3cabee6d4789d0e8fa8dd824b01783f301b0fdd43e632f7 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ild (#1992) Bumps ubi8/ubi-minimal from `7b6b45d` to `2139859`. --- updated-dependencies: - dependency-name: ubi8/ubi-minimal dependency-version: 21398599ff11971e5084dae6f5fb8fd880b4b430b4dc2bc80780916066a9695e dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [actions/cache](https://github.com/actions/cache) from 4 to 5. - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](actions/cache@v4...v5) --- updated-dependencies: - dependency-name: actions/cache dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…upgrade (#1991) Signed-off-by: nmirasch <neus.miras@gmail.com>
* GITOPS-8249- added mapping of timeout.reconciliation to env var Signed-off-by: Alka Kumari <alkumari@redhat.com> * commit for retriggering the pipeline Signed-off-by: Alka Kumari <alkumari@redhat.com> --------- Signed-off-by: Alka Kumari <alkumari@redhat.com>
Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com>
|
Important Review skippedToo many files! This PR contains 1074 files, which is 774 over the limit of 300. To get a review, reduce the PR to 300 files or fewer by splitting it into smaller PRs or changing its base branch. ⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (13)
📒 Files selected for processing (1074)
You can disable this status message by setting the Use the checkbox below for a quick retry:
|
Signed-off-by: Oliver Gondža <ogondza@gmail.com>
Collaborator
Author
|
Suspected flake
|
Signed-off-by: Oliver Gondža <ogondza@gmail.com>
olivergondza
force-pushed
the
internalize-argocd-operator-fr
branch
3 times, most recently
from
September 10, 2026 08:25
5c6180c to
cdd3c5a
Compare
Collaborator
Author
|
/test unit |
This reverts commit 2d3be52.
Signed-off-by: Oliver Gondža <ogondza@gmail.com>
olivergondza
force-pushed
the
internalize-argocd-operator-fr
branch
from
September 10, 2026 09:02
cdd3c5a to
b1eb54a
Compare
Collaborator
Author
|
@anandf, @jgwest, @svghadi, @jannfis, Please prioritize taking a look. Effective changes post merge: https://github.com/olivergondza/gitops-operator/commits/internalize-argocd-operator-fr/?since=2026-09-09 |
…rnetes.io token Signed-off-by: Oliver Gondža <ogondza@gmail.com>
Collaborator
Author
|
Adding |
Collaborator
Author
|
/retest |
1 similar comment
Collaborator
Author
|
/retest |
anandf
requested changes
Sep 11, 2026
Collaborator
Author
|
@anandf, I kept this PR minimal in changes on purpose - it is huge already. The idea was and still is to make the switch that blocks almost all contributions fast, and then drop what become unused later. Tracked as https://redhat.atlassian.net/browse/GITOPS-10900, I will amend it with your suggestions. |
anandf
approved these changes
Sep 11, 2026
Member
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jannfis The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Collaborator
Author
|
/test v4.19-kuttl-sequential |
|
@olivergondza: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do / why we need it:
This is a first step in factoring-in the argocd-operator. It purposefully does the minimum, to move forward in manageable steps. The goal of the PR is to do just enough for CI to pass to provide the needed safety net and have the codebase releasable.
Effective changes post merge: https://github.com/olivergondza/gitops-operator/commits/internalize-argocd-operator-fr/?since=2026-09-09
go.modreplace for a new directoryargocd-operatoron018b360b1a9fe53b88ef2c5fb2aa143cd4b4b539.git filter-repo+git merge --allow-unrelated-historiesHave you updated the necessary documentation?
Which issue(s) this PR fixes:
Fixes #?
Test acceptance criteria:
How to test changes / Special notes to the reviewer:
The exact procedure used to internalize the remote repository.
!!! DO NOT SQUASH-MERGE !!!