Skip to content

chore: remove reference to external repo - #1289

Open
jgwest wants to merge 1 commit into
redhat-developer:masterfrom
jgwest:remove-old-repo-reference-sept-2026
Open

chore: remove reference to external repo#1289
jgwest wants to merge 1 commit into
redhat-developer:masterfrom
jgwest:remove-old-repo-reference-sept-2026

Conversation

@jgwest

@jgwest jgwest commented Sep 10, 2026

Copy link
Copy Markdown
Member

What type of PR is this?
/kind cleanup

What does this PR do / why we need it:

  • Remove reference to external GitHub repo from tests.
  • We already have a replacement for this within the repo.

Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • Documentation has been updated.

Test acceptance criteria:

  • Unit Test
  • E2E Test

How to test changes / Special notes to the reviewer:

Signed-off-by: Jonathan West <jgwest@gmail.com>
@openshift-ci openshift-ci Bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process. label Sep 10, 2026
@openshift-ci

openshift-ci Bot commented Sep 10, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign chengfang for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Sep 10, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 12baffb6-6205-469a-be40-9c8c8f12e6a9

📥 Commits

Reviewing files that changed from the base of the PR and between c677b50 and 3c47f68.

📒 Files selected for processing (2)
  • test/openshift/e2e/ginkgo/sequential/1-027_validate_operand_from_git_test.go
  • test/openshift/e2e/ginkgo/sequential/1-064_validate_tcp_reset_error_test.go
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • argoproj-labs/argocd-operator (manual)

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


📝 Summary

Summary by CodeRabbit

  • Tests
    • Updated end-to-end test scenarios to use the GitOps Operator repository and its current example path.
    • Improved test reliability by replacing references to a legacy external repository.

Walkthrough

Two sequential end-to-end tests now source the operand manifests from redhat-developer/gitops-operator at ./test/examples/1-027_operand-from-git.

Changes

Application Git source updates

Layer / File(s) Summary
Application Git source updates
test/openshift/e2e/ginkgo/sequential/1-027_validate_operand_from_git_test.go, test/openshift/e2e/ginkgo/sequential/1-064_validate_tcp_reset_error_test.go
Both tests now use the GitOps Operator repository and the repository-local operand example path. The obsolete relocation TODO is removed.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 3c47f

The two end-to-end tests now use the repository-internal GitOps Operator example instead of an external repository. No actionable merge-blocking risk is evident.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: removing references to an external repository from tests.
Description check ✅ Passed The description directly explains that the tests will use an existing repository-internal replacement instead of an external GitHub repository.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Comment @coderabbitai help to get the list of available commands.

@jgwest

jgwest commented Sep 10, 2026

Copy link
Copy Markdown
Member Author

/retest

@jgwest

jgwest commented Sep 11, 2026

Copy link
Copy Markdown
Member Author

/retest

on: failed to list *v1.ClusterVersion: Get "https://api.ci-op-rfsdv6qb-3fe53.ocp-gitops-qe.com:6443/apis/config.openshift.io/v1/clusterversions?fieldSelector=metadata.name%3Dversion&limit=500&resourceVersion=0": dial tcp 52.43.144.19:6443: connect: connection refused
W0910 18:55:11.254997     235 reflector.go:533] k8s.io/client-go/tools/watch/informerwatcher.go:146: failed to list *v1.ClusterVersion: Get "https://api.ci-op-rfsdv6qb-3fe53.ocp-gitops-qe.com:6443/apis/config.openshift.io/v1/clusterversions?fieldSelector=metadata.name%3Dversion&limit=500&resourceVersion=0": dial tcp 52.43.144.19:6443: connect: connection refused
E0910 18:55:11.255064     235 reflector.go:148] k8s.io/client-go/tools/watch/informerwatcher.go:146: Failed to watch *v1.ClusterVersion: failed to list *v1.ClusterVersion: Get "https://api.ci-op-rfsdv6qb-3fe53.ocp-gitops-qe.com:6443/apis/config.openshift.io/v1/clusterversions?fieldSelector=metadata.name%3Dversion&limit=500&resourceVersion=0": dial tcp 52.43.144.19:6443: connect: connection refused
W0910 18:55:51.104892     235 reflector.go:533] k8s.io/client-go/tools/watch/informerwatcher.go:146: failed to list *v1.ClusterVersion: Get "https://api.ci-op-rfsdv6qb-3fe53.ocp-gitops-qe.com:6443/apis/config.openshift.io/v1/clusterversions?fieldSelector=metadata.name%3Dversion&limit=500&resourceVersion=0": dial tcp 52.43.144.19:6443: connect: connection refused
E0910 18:55:51.104935     235 reflector.go:148] k8s.io/client-go/tools/watch/informerwatcher.go:146: Failed to watch *v1.ClusterVersion: failed to list *v1.ClusterVersion: Get "https://api.ci-op-rfsdv6qb-3fe53.ocp-gitops-qe.com:6443/apis/config.openshift.io/v1/clusterversions?fieldSelector=metadata.name%3Dversion&limit=500&resourceVersion=0": dial tcp 52.43.144.19:6443: connect: connection refused
level=error msg=Attempted to gather ClusterOperator status after installation failure: listing ClusterOperator objects: Get "https://api.ci-op-rfsdv6qb-3fe53.ocp-gitops-qe.com:6443/apis/config.openshift.io/v1/clusteroperators": dial tcp 52.43.144.19:6443: connect: connection refused
level=error msg=Cluster initialization failed because one or more operators are not functioning properly.
level=error msg=The cluster should be accessible for troubleshooting as detailed in the documentation linked below,
level=error msg=https://docs.openshift.com/container-platform/latest/support/troubleshooting/troubleshooting-installations.html
level=error msg=The 'wait-for install-complete' subcommand can then be used to continue the installation
level=error msg=failed to initialize the cluster: timed out waiting for the condition
Installer exit with code 6
Releasing install leases (if any)
Tear down the backgroup process of copying kube config

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/cleanup Categorizes issue or PR as related to cleaning up code, process.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant