Fix builds with multisession support disabled - #20
Merged
Conversation
Declare the session-candidate TOC only when multisession support is enabled, matching the guard around its users. This fixes the unused variable error when ODFS_FEATURE_MULTISESSION=0 is built with -Werror. Compile the host library with multisession disabled in CI, using a separate output directory so default-build objects cannot hide the regression.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Building with
ODFS_FEATURE_MULTISESSION=0fails under-Werrorbecausemount_build_session_candidates()still declarestocwhile all of its uses are compiled out. Guard the declaration with the same feature flag.Add a CI build of the host library with multisession disabled in a separate output directory to catch this configuration regression without reusing default-build objects.
Validation:
ODFS_FEATURE_MULTISESSION=0passed.FEATURE_MULTISESSION=0passed.