Skip to content

Upgrade to Ruby 4.0.10, shared-core 8.7.1 and refresh dependencies - #24

Merged
igalshilman merged 2 commits into
mainfrom
chore/ruby-4.0.10-deps-refresh
Nov 19, 2026
Merged

igalshilman merged 2 commits into
mainfrom
chore/ruby-4.0.10-deps-refresh

Conversation

@igalshilman

@igalshilman igalshilman commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Summary

General maintenance

Ruby

  • Ruby 4.0.10 in ci.yaml, pullfrog.yml, release.yml and test-services/Dockerfile
  • ruby/setup-ruby v1.335.0 → v1.342.0, the first release that knows 4.0.10
  • shell.nix: Ruby 4.0.10 via a local mkRuby override, which removes itself once the nixpkgs channel ships 4.0.10

Rust

  • restate-sdk-shared-core 8.2.0 → 8.7.1. The changes are additive, with no service-protocol bump.
  • magnus 0.8 → 0.9, rb-sys 0.9.130, cargo update
  • The crate moves to edition 2024. The lib.rs diff is only cargo fmt and import sorting.

Gems

  • bundle update for every gem; Bundler 4.1.0
  • New Style/DirectiveScope cop fixed in context.rb

Bug fixes found while testing on Ruby 4

  • base64 and logger are now runtime dependencies in the gemspec. They stopped being default gems in Ruby 3.4 and 4.0 respectively, so the SDK failed to load under Bundler. The dev Gemfile had been hiding this.
  • test-services/entrypoint.sh no longer pins GEM_PATH, which hid Ruby's bundled gems and made the Falcon workers crash on boot.

Tooling

  • etc/run-integration-tests.sh now uses sdk-test-suite v2.3, matching CI, run on an eclipse-temurin:25-jre image

Notes for review

  • .github/workflows/actions.lock was edited by hand: only the ruby/setup-ruby ref and SHA changed, because gh actions-lock wasn't available. The verify-lockfile check will confirm it.
  • The release setup-ruby-and-rust step uses "4.0" rather than an exact pin. It resolves through a locked setup-ruby-pkgs commit and only drives rb-sys-dock.
  • required_ruby_version stays at >= 3.1. magnus 0.9 no longer tests against 3.1, so it may be worth raising the floor in a follow-up.

Testing

  • make verify: no rubocop offenses; steep and sorbet clean; 29 harness specs pass
  • Unit specs: 60 examples, 0 failures
  • ./etc/run-integration-tests.sh against a Ruby 4.0.10 image: 322/322 passed

Ruby 4.0.10 fixes the regexp/string vulnerabilities announced on
2026-11-18 (4.0.9 and earlier are affected).

- Ruby 4.0.10 in CI, pullfrog, release and the test-services image;
  ruby/setup-ruby v1.342.0 (first release that knows 4.0.10)
- shell.nix: Ruby 4.0.10 (local mkRuby override until nixpkgs has it)
- restate-sdk-shared-core 8.2.0 -> 8.7.1, magnus 0.8 -> 0.9,
  rb-sys 0.9.130, cargo update; crate moved to edition 2024 + cargo fmt
- bundle update (all gems), Bundler 4.1.0
- Declare base64 and logger as runtime dependencies: they are no longer
  default gems on Ruby >= 3.4 / 4.0 and fail to load under Bundler
- test-services entrypoint: stop pinning GEM_PATH, which hid Ruby's
  bundled gems from Bundler at runtime
- Integration script: sdk-test-suite v2.3 (matching CI) on a Java 25
  runner image
@pullfrog

pullfrog Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

The workflow's Set up job step failed, so Pullfrog never ran. That step runs before Pullfrog in this repo's workflow, so the fix is in the workflow or that step's own setup.

GitHub's error
lockfile verification did not produce a result for this action. Lockfile pin b725eda525362e7cf34af9a7243cac1e3f01a7ec for `dtolnay/rust-toolchain` does not match ref `stable`. Ensure the pinned commit exists on the expected branch or tag. lockfile verification did not produce a result for this action

View the step's logs →

Pullfrog  | Rerun failed job ➔ | View workflow run | via Pullfrog

The previously locked commit was force-pushed out of the stable branch's
history, which fails every job that uses the action.
@pullfrog

pullfrog Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

The workflow's Set up job step failed, so Pullfrog never ran. That step runs before Pullfrog in this repo's workflow, so the fix is in the workflow or that step's own setup.

GitHub's error
lockfile verification did not produce a result for this action. Lockfile pin b725eda525362e7cf34af9a7243cac1e3f01a7ec for `dtolnay/rust-toolchain` does not match ref `stable`. Ensure the pinned commit exists on the expected branch or tag. lockfile verification did not produce a result for this action

View the step's logs →

Pullfrog  | Rerun failed job ➔ | View workflow run | via Pullfrog

@igalshilman

Copy link
Copy Markdown
Contributor Author

@pullfrog try again please

@pullfrog

pullfrog Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

The workflow's Set up job step failed, so Pullfrog never ran. That step runs before Pullfrog in this repo's workflow, so the fix is in the workflow or that step's own setup.

GitHub's error
lockfile verification did not produce a result for this action. Lockfile pin b725eda525362e7cf34af9a7243cac1e3f01a7ec for `dtolnay/rust-toolchain` does not match ref `stable`. Ensure the pinned commit exists on the expected branch or tag. lockfile verification did not produce a result for this action

View the step's logs →

Pullfrog  | Rerun failed job ➔ | View workflow run | via Pullfrog

@github-actions

Copy link
Copy Markdown

Test Results

  8 files  ±0    8 suites  ±0   4m 48s ⏱️ +45s
 71 tests ±0   71 ✅ ±0  0 💤 ±0  0 ❌ ±0 
322 runs  ±0  322 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit de7531c. ± Comparison against base commit f65c084.

@igalshilman
igalshilman merged commit 597dfde into main Nov 19, 2026
4 of 5 checks passed
@igalshilman
igalshilman deleted the chore/ruby-4.0.10-deps-refresh branch November 19, 2026 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant