Repository navigation
Avoid allocating the torrent output path twice - #323
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Saving a torrent allocates its output path twice with identical
file_modify_path()calls. The second call overwrites the first allocation, leaking a path for every saved torrent. Remove the unused first call and retain the existing error-handling call.Closes #315. Extracted as an independent fix from #321.
Validation: compiled the focused patch against master 3dbba4b on Ubuntu/GCC 13.3 with AddressSanitizer and SHA-NI disabled. Actual
rhash --torrent tests/test1K.datasaves the torrent and exits successfully without a leak report. Restoring only the duplicate call in a control build produces a LeakSanitizer report of 26 bytes in onestr_replace_nallocation and exits 1.git diff --checkpasses. Other platforms and the full CLI suite were not exercised for this focused patch.