chore: port agnosticg charts to helm repo - #3
Open
evanshortiss wants to merge 26 commits into
Open
evanshortiss wants to merge 26 commits into
evanshortiss wants to merge 26 commits into
Conversation
Add selectattr guards for undefined status, sync, and health fields to prevent errors when child Applications haven't been fully reconciled yet. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Align developerHub block with restructured helm values: replace configTemplate with config, remove rootPassword/cluster/subdomain, pass argocd/kubernetes/gitlab/backstage hosts directly. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Enables RBAC customization on the openshift-gitops instance with role:readonly default, scopes including email for user-based policies, and pe1 granted full access to the pe-workshop AppProject with read-only access to default. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Dex passes the OpenShift user UUID as the subject, not the username. Adding preferred_username to scopes ensures Argo CD RBAC policies can match against the pe1 username. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Remove custom GitOps operator installation in favor of the reusable ocp4_workload_openshift_gitops role from core_workloads. This enables: - Use of modern resourceHealthChecks API for custom health checks - Consistent GitOps setup across RHDP workshops - Centralized maintenance of GitOps configurations The workload role still retrieves the admin password for user info reporting. GitOps installation is now controlled via the ocp4_workload_platform_engineering_workshop_openshift_gitops_install variable in AgnosticV configs (set to false in dev.yaml). Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
BREAKING CHANGE: GitOps operator installation is now delegated to the ocp4_workload_openshift_gitops role from core_workloads. This role no longer installs or configures the GitOps operator. Removed: - tasks/openshift_gitops.yml (operator installation task) - files/openshift_gitops_clusterrolebinding.yaml - templates/openshift-gitops/openshift-gitops.yaml.j2 - All ocp4_workload_platform_engineering_workshop_openshift_gitops_* variables from defaults/main.yml The cluster-level openshift-gitops ArgoCD instance is now configured via AgnosticV using ocp4_workload_openshift_gitops. The rhdh-gitops ArgoCD instance continues to be deployed via the gitops Helm chart in ocp-pe-wkshp-helm-infra. Migration: Set ocp4_workload_platform_engineering_workshop_openshift_gitops_install to false in AgnosticV configs and add ocp4_workload_openshift_gitops to the workloads list before this workload. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.